Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix the conflict between tiflash learner and location labels #6671

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jun 25, 2023

Cherry-pick for #6660.

What problem does this PR solve?

Issue Number: Close #6662.

What is changed and how does it work?

This PR only chooses the source store that is contained in the rule.

Check List

Tests

  • Unit test

Release note

None.

@JmPotato JmPotato requested review from nolouch and rleungx June 25, 2023 09:41
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (614ecda) 75.64% compared to head (77324b4) 75.69%.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           release-6.5-20230620-v6.5.2    #6671      +/-   ##
===============================================================
+ Coverage                        75.64%   75.69%   +0.04%     
===============================================================
  Files                              330      330              
  Lines                            32982    32983       +1     
===============================================================
+ Hits                             24950    24966      +16     
+ Misses                            5878     5871       -7     
+ Partials                          2154     2146       -8     
Flag Coverage Δ
unittests 75.69% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker/rule_checker.go 81.58% <100.00%> (+0.06%) ⬆️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JmPotato JmPotato merged commit e7ea0c9 into tikv:release-6.5-20230620-v6.5.2 Jun 25, 2023
18 checks passed
@JmPotato JmPotato deleted the cp_6660 branch June 25, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants