Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update version to show all instance cpu limit (#6678) #6692

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6678

What problem does this PR solve?

Issue Number: ref #6415

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

before
image
after
image

Release note

None.

Signed-off-by: husharp <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 27, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jun 27, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 27, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx June 27, 2023 03:01
@HuSharp HuSharp requested review from nolouch, CabinfeverB and HuSharp and removed request for JmPotato and rleungx June 27, 2023 03:23
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (2949a53) 74.84% compared to head (e040d77) 74.86%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #6692      +/-   ##
===============================================
+ Coverage        74.84%   74.86%   +0.01%     
===============================================
  Files              408      408              
  Lines            40745    40745              
===============================================
+ Hits             30496    30502       +6     
  Misses            7566     7566              
+ Partials          2683     2677       -6     
Flag Coverage Δ
unittests 74.86% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old version is d6e0218addd5, same as master. It's safe. LGTM!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 27, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 27, 2023
@CabinfeverB
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e040d77

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit eeaf839 into tikv:release-7.1 Jun 27, 2023
18 checks passed
@HuSharp HuSharp deleted the cherry-pick-6678-to-release-7.1 branch June 27, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants