Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr-autosync: move state replicate to different goroutine (#6874) #6705

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jun 28, 2023

What problem does this PR solve?

Issue Number: Fix #6883

What is changed and how does it work?

cherry-pick #6874

Check List

Tests

  • Unit test

Release note

None.

@disksing disksing added the status/DNM Do not merge this PR. label Jun 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jun 28, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx June 28, 2023 08:26
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 45.00% and project coverage change: +0.08% 🎉

Comparison is base (2892b46) 75.54% compared to head (dc56b82) 75.62%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6705      +/-   ##
===============================================
+ Coverage        75.54%   75.62%   +0.08%     
===============================================
  Files              328      328              
  Lines            33168    33171       +3     
===============================================
+ Hits             25056    25087      +31     
+ Misses            5944     5931      -13     
+ Partials          2168     2153      -15     
Flag Coverage Δ
unittests 75.62% <45.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/replication/replication_mode.go 75.57% <45.00%> (-3.38%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disksing disksing changed the title dr autosync: speed up state change dr-autosync: move state replicate to different goroutine (#6874) Aug 2, 2023
@disksing disksing requested review from nolouch and lhy1024 and removed request for JmPotato and rleungx August 2, 2023 08:23
@disksing disksing added type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. and removed status/DNM Do not merge this PR. labels Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2023
@disksing
Copy link
Contributor Author

disksing commented Aug 2, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: dc56b82

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 198860d into tikv:release-6.5 Aug 2, 2023
16 of 17 checks passed
@disksing disksing deleted the disksing/dr-replicate-2 branch August 2, 2023 10:05
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants