Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: decouple the scheduler and checker interfaces #6776

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 7, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

The PR makes the interface usage more clear. SchedulerCluster represents the methods that the schedulers need. CheckerCluster represents the methods that the checkers need. SharedCluster represents the methods that both schedulers and checkers need. The definitions are the same as config.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 July 7, 2023 11:52
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@rleungx rleungx requested review from JmPotato, nolouch and CabinfeverB and removed request for disksing July 11, 2023 03:37
@rleungx
Copy link
Member Author

rleungx commented Jul 14, 2023

@nolouch @JmPotato PTAL

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2023
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2023
@rleungx
Copy link
Member Author

rleungx commented Jul 14, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a2cda87

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #6776 (476c126) into master (c8f88e4) will increase coverage by 0.12%.
The diff coverage is 81.57%.

❗ Current head 476c126 differs from pull request most recent head 37a653a. Consider uploading reports for the commit 37a653a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6776      +/-   ##
==========================================
+ Coverage   74.17%   74.29%   +0.12%     
==========================================
  Files         413      413              
  Lines       43406    43178     -228     
==========================================
- Hits        32196    32080     -116     
+ Misses       8334     8236      -98     
+ Partials     2876     2862      -14     
Flag Coverage Δ
unittests 74.29% <81.57%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 727d027 into tikv:master Jul 14, 2023
19 checks passed
@rleungx rleungx deleted the cleanup-interface branch July 14, 2023 09:54
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants