Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global config: fix etcd client not found #6866

Merged
merged 3 commits into from
Jul 31, 2023
Merged

global config: fix etcd client not found #6866

merged 3 commits into from
Jul 31, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jul 31, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #6860 #6858

What is changed and how does it work?

Check List

Tests

  • Integration test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jul 31, 2023
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx July 31, 2023 08:13
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2023
@HuSharp HuSharp requested review from bufferflies and removed request for rleungx July 31, 2023 08:13
@HuSharp
Copy link
Member Author

HuSharp commented Jul 31, 2023

/check-issue-triage-complete

@HuSharp
fix etcd not found
56f5844 
Signed-off-by: husharp <[email protected]>
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #6866 (56f5844) into master (ef81248) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 56f5844 differs from pull request most recent head 449d2b2. Consider uploading reports for the commit 449d2b2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6866      +/-   ##
==========================================
- Coverage   74.17%   74.10%   -0.08%     
==========================================
  Files         419      418       -1     
  Lines       44079    44005      -74     
==========================================
- Hits        32697    32610      -87     
- Misses       8470     8479       +9     
- Partials     2912     2916       +4
Flag Coverage Δ
unittests 74.10% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2023
lhy1024
lhy1024 reviewed Jul 31, 2023
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
server/grpc_service.go Show resolved Hide resolved
@HuSharp
address comment
747308f 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 31, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Jul 31, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 449d2b2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit c97dfcb into tikv:master Jul 31, 2023
19 checks passed
@HuSharp HuSharp deleted the fix_etcd_client_panic branch July 31, 2023 14:09
This was referenced Aug 2, 2023
Closed
Merged
@HuSharp HuSharp added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 10, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #6935.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 10, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#6866
ac4b4d9 
close tikv#6860

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 10, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Aug 10, 2023
@ti-chi-bot @HuSharp
global config: fix etcd client not found (#6866) (#6935)
e34a0a3 
close #6860

Signed-off-by: husharp <[email protected]>

Co-authored-by: husharp <[email protected]>
@HuSharp HuSharp added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Aug 10, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #6942.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 10, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #6943.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 10, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#6866
b6655f0 
close tikv#6860

Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Aug 10, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6944.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 10, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#6866
bb287a4 
close tikv#6860

Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 10, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#6866
8922a7e 
close tikv#6860

Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 10, 2023
@ti-chi-bot @HuSharp
global config: fix etcd client not found (#6866) (#6942)
41a070b 
close #6860

Signed-off-by: husharp <[email protected]>

Co-authored-by: husharp <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 11, 2023
@ti-chi-bot @HuSharp
global config: fix etcd client not found (#6866) (#6943)
21b47d2 
close #6860

Signed-off-by: husharp <[email protected]>

Co-authored-by: husharp <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 11, 2023
@ti-chi-bot @HuSharp
global config: fix etcd client not found (#6866) (#6944)
df147b3 
close #6860

Signed-off-by: husharp <[email protected]>

Co-authored-by: husharp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@bufferflies bufferflies bufferflies approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: WatchGlobalConfig
5 participants
@HuSharp @lhy1024 @ti-chi-bot @bufferflies @rleungx