Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make coordinator run #6896

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 4, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

[2023/08/04 16:48:08.944 +08:00] [INFO] [versioninfo.go:89] ["Welcome to Placement Driver (SCHEDULING)"]
[2023/08/04 16:48:08.944 +08:00] [INFO] [versioninfo.go:90] [SCHEDULING] [release-version=v7.4.0-alpha-3-g09921f5e5-dirty]
[2023/08/04 16:48:08.944 +08:00] [INFO] [versioninfo.go:91] [SCHEDULING] [edition=Community]
[2023/08/04 16:48:08.944 +08:00] [INFO] [versioninfo.go:92] [SCHEDULING] [git-hash=09921f5e513d7b38be9d1fe33943a9e70309a442]
[2023/08/04 16:48:08.944 +08:00] [INFO] [versioninfo.go:93] [SCHEDULING] [git-branch=remove-some-store-config]
[2023/08/04 16:48:08.944 +08:00] [INFO] [versioninfo.go:94] [SCHEDULING] [utc-build-time="2023-08-04 08:46:21"]
[2023/08/04 16:48:08.944 +08:00] [INFO] [server.go:613] ["Scheduling config"] [config="{\"backend-endpoints\":\"http://127.0.0.1:2379\",\"listen-addr\":\"http://127.0.0.1:3379\",\"advertise-listen-addr\":\"http://127.0.0.1:3379\",\"name\":\"Scheduling-cloud-ecosystem-00\",\"data-dir\":\"/data/nvme0n1/ryan/workspace/pd/default.Scheduling-cloud-ecosystem-00\",\"enable-grpc-gateway\":true,\"metric\":{\"job\":\"\",\"address\":\"\",\"interval\":\"0s\"},\"log\":{\"level\":\"info\",\"format\":\"text\",\"disable-timestamp\":false,\"file\":{\"filename\":\"\",\"max-size\":0,\"max-days\":0,\"max-backups\":0},\"development\":false,\"disable-caller\":false,\"disable-stacktrace\":false,\"disable-error-verbose\":true,\"sampling\":null,\"error-output-path\":\"\"},\"Logger\":{},\"LogProps\":{\"Core\":{\"LevelEnabler\":\"info\"},\"Syncer\":{},\"Level\":\"info\"},\"security\":{\"cacert-path\":\"\",\"cert-path\":\"\",\"key-path\":\"\",\"cert-allowed-cn\":null,\"SSLCABytes\":null,\"SSLCertBytes\":null,\"SSLKEYBytes\":null,\"redact-info-log\":false,\"encryption\":{\"data-encryption-method\":\"plaintext\",\"data-key-rotation-period\":\"168h0m0s\",\"master-key\":{\"type\":\"plaintext\",\"key-id\":\"\",\"region\":\"\",\"endpoint\":\"\",\"path\":\"\"}}},\"WarningMsgs\":null,\"lease\":3,\"cluster-version\":\"0.0.0\",\"schedule\":{\"max-snapshot-count\":64,\"max-pending-peer-count\":64,\"max-merge-region-size\":20,\"max-merge-region-keys\":0,\"split-merge-interval\":\"1h0m0s\",\"switch-witness-interval\":\"1h0m0s\",\"enable-one-way-merge\":\"false\",\"enable-cross-table-merge\":\"true\",\"patrol-region-interval\":\"10ms\",\"max-store-down-time\":\"30m0s\",\"max-store-preparing-time\":\"48h0m0s\",\"leader-schedule-limit\":4,\"leader-schedule-policy\":\"count\",\"region-schedule-limit\":2048,\"witness-schedule-limit\":4,\"replica-schedule-limit\":64,\"merge-schedule-limit\":8,\"hot-region-schedule-limit\":4,\"hot-region-cache-hits-threshold\":3,\"store-limit\":{},\"tolerant-size-ratio\":0,\"low-space-ratio\":0.8,\"high-space-ratio\":0.7,\"region-score-formula-version\":\"v2\",\"scheduler-max-waiting-operator\":5,\"enable-remove-down-replica\":\"true\",\"enable-replace-offline-replica\":\"true\",\"enable-make-up-replica\":\"true\",\"enable-remove-extra-replica\":\"true\",\"enable-location-replacement\":\"true\",\"enable-debug-metrics\":\"false\",\"enable-joint-consensus\":\"true\",\"enable-tikv-split-region\":\"true\",\"schedulers-v2\":[{\"type\":\"balance-region\",\"args\":null,\"disable\":false,\"args-payload\":\"\"},{\"type\":\"balance-leader\",\"args\":null,\"disable\":false,\"args-payload\":\"\"},{\"type\":\"balance-witness\",\"args\":null,\"disable\":false,\"args-payload\":\"\"},{\"type\":\"hot-region\",\"args\":null,\"disable\":false,\"args-payload\":\"\"},{\"type\":\"transfer-witness-leader\",\"args\":null,\"disable\":false,\"args-payload\":\"\"}],\"schedulers-payload\":null,\"hot-regions-write-interval\":\"10m0s\",\"hot-regions-reserved-days\":7,\"max-movable-hot-peer-size\":512,\"enable-diagnostic\":\"true\",\"enable-witness\":\"false\",\"slow-store-evicting-affected-store-ratio-threshold\":0.3,\"store-limit-version\":\"v1\"},\"replication\":{\"max-replicas\":3,\"location-labels\":\"\",\"strictly-match-label\":\"false\",\"enable-placement-rules\":\"true\",\"enable-placement-rules-cache\":\"false\",\"isolation-level\":\"\"}}"]
[2023/08/04 16:48:08.945 +08:00] [INFO] [metricutil.go:86] ["disable Prometheus push client"]
[2023/08/04 16:48:08.947 +08:00] [INFO] [server.go:479] ["init cluster id"] [cluster-id=7263376508257569687]
[2023/08/04 16:48:08.947 +08:00] [INFO] [server.go:486] ["joining primary election"] [participant-name=http://127.0.0.1:3379] [participant-id=2055417977794868804]
[2023/08/04 16:48:08.947 +08:00] [INFO] [participant.go:84] ["participant joining election"] [participant-info="name:\"http://127.0.0.1:3379\" id:2055417977794868804 listen_urls:\"http://127.0.0.1:3379\" "] [leader-path=/ms/7263376508257569687/scheduling/00000/primary]
[2023/08/04 16:48:08.949 +08:00] [INFO] [etcdutil.go:670] ["load finished in watch loop"] [name=scheduling-config-watcher] [key=/pd/7263376508257569687/config]
[2023/08/04 16:48:08.949 +08:00] [INFO] [etcdutil.go:608] ["start to watch loop"] [name=scheduling-config-watcher] [key=/pd/7263376508257569687/config]
[2023/08/04 16:48:08.950 +08:00] [INFO] [etcdutil.go:670] ["load finished in watch loop"] [name=scheduling-rule-watcher] [key=/pd/7263376508257569687/rules]
[2023/08/04 16:48:08.950 +08:00] [INFO] [etcdutil.go:608] ["start to watch loop"] [name=scheduling-rule-watcher] [key=/pd/7263376508257569687/rules]
[2023/08/04 16:48:08.950 +08:00] [INFO] [etcdutil.go:670] ["load finished in watch loop"] [name=scheduling-rule-group-watcher] [key=/pd/7263376508257569687/rule_group]
[2023/08/04 16:48:08.950 +08:00] [INFO] [etcdutil.go:608] ["start to watch loop"] [name=scheduling-rule-group-watcher] [key=/pd/7263376508257569687/rule_group]
[2023/08/04 16:48:08.951 +08:00] [INFO] [etcdutil.go:670] ["load finished in watch loop"] [name=scheduling-region-label-watcher] [key=/pd/7263376508257569687/region_label]
[2023/08/04 16:48:08.951 +08:00] [INFO] [etcdutil.go:608] ["start to watch loop"] [name=scheduling-region-label-watcher] [key=/pd/7263376508257569687/region_label]
[2023/08/04 16:48:08.951 +08:00] [INFO] [coordinator.go:332] ["Coordinator starts to collect cluster information"]
[2023/08/04 16:48:08.951 +08:00] [INFO] [coordinator.go:335] ["Coordinator has finished cluster information preparation"]
[2023/08/04 16:48:08.951 +08:00] [INFO] [coordinator.go:345] ["Coordinator starts to run schedulers"]
[2023/08/04 16:48:08.951 +08:00] [INFO] [server.go:348] ["grpc server starts serving"] [address=127.0.0.1:3379]
[2023/08/04 16:48:08.951 +08:00] [INFO] [server.go:361] ["http server starts serving"] [address=127.0.0.1:3379]
[2023/08/04 16:48:08.951 +08:00] [INFO] [server.go:530] ["triggering the start callback functions"]
[2023/08/04 16:48:08.952 +08:00] [INFO] [server.go:200] ["start to campaign the primary/leader"] [campaign-scheduling-primary-name=http://127.0.0.1:3379]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:392] ["the scheduler type not found"] [scheduler-name=balance-hot-region-scheduler] [error="[PD:scheduler:ErrSchedulerNotFound]scheduler not found"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:392] ["the scheduler type not found"] [scheduler-name=balance-leader-scheduler] [error="[PD:scheduler:ErrSchedulerNotFound]scheduler not found"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:392] ["the scheduler type not found"] [scheduler-name=balance-region-scheduler] [error="[PD:scheduler:ErrSchedulerNotFound]scheduler not found"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:392] ["the scheduler type not found"] [scheduler-name=balance-witness-scheduler] [error="[PD:scheduler:ErrSchedulerNotFound]scheduler not found"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:392] ["the scheduler type not found"] [scheduler-name=transfer-witness-leader-scheduler] [error="[PD:scheduler:ErrSchedulerNotFound]scheduler not found"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:422] ["can not create scheduler"] [scheduler-type=balance-region] [scheduler-args="[]"] [error="[PD:scheduler:ErrSchedulerCreateFuncNotRegistered]create func of balance-region is not registered"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:422] ["can not create scheduler"] [scheduler-type=balance-leader] [scheduler-args="[]"] [error="[PD:scheduler:ErrSchedulerCreateFuncNotRegistered]create func of balance-leader is not registered"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:422] ["can not create scheduler"] [scheduler-type=balance-witness] [scheduler-args="[]"] [error="[PD:scheduler:ErrSchedulerCreateFuncNotRegistered]create func of balance-witness is not registered"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:422] ["can not create scheduler"] [scheduler-type=hot-region] [scheduler-args="[]"] [error="[PD:scheduler:ErrSchedulerCreateFuncNotRegistered]create func of hot-region is not registered"]
[2023/08/04 16:48:08.952 +08:00] [ERROR] [coordinator.go:422] ["can not create scheduler"] [scheduler-type=transfer-witness-leader] [scheduler-args="[]"] [error="[PD:scheduler:ErrSchedulerCreateFuncNotRegistered]create func of transfer-witness-leader is not registered"]
[2023/08/04 16:48:08.952 +08:00] [INFO] [coordinator.go:301] ["Coordinator begins to actively drive push operator"]
[2023/08/04 16:48:08.952 +08:00] [INFO] [coordinator.go:129] ["Coordinator starts patrol regions"]
[2023/08/04 16:48:08.952 +08:00] [INFO] [coordinator.go:237] ["Coordinator begins to check suspect key ranges"]
[2023/08/04 16:48:08.952 +08:00] [INFO] [lease.go:66] ["lease granted"] [lease-id=2463901927147700502] [lease-timeout=3] [purpose="primary election"]
[2023/08/04 16:48:08.953 +08:00] [INFO] [leadership.go:130] ["check campaign resp"] [resp="{\"header\":{\"cluster_id\":15674009460217235928,\"member_id\":3474484975246189105,\"revision\":1539,\"raft_term\":2},\"succeeded\":true,\"responses\":[{\"Response\":{\"ResponsePut\":{\"header\":{\"revision\":1539}}}}]}"]
[2023/08/04 16:48:08.953 +08:00] [INFO] [leadership.go:139] ["write leaderData to leaderPath ok"] [leaderPath=/ms/7263376508257569687/scheduling/00000/primary] [purpose="primary election"]
[2023/08/04 16:48:08.953 +08:00] [INFO] [server.go:223] ["campaign scheduling primary ok"] [campaign-scheduling-primary-name=http://127.0.0.1:3379]
[2023/08/04 16:48:08.953 +08:00] [INFO] [server.go:225] ["triggering the primary callback functions"]
[2023/08/04 16:48:08.953 +08:00] [INFO] [server.go:231] ["scheduling primary is ready to serve"] [scheduling-primary-name=http://127.0.0.1:3379]
[2023/08/04 16:48:08.953 +08:00] [INFO] [lease.go:155] ["start lease keep alive worker"] [interval=1s] [purpose="primary election"]
^C[2023/08/04 16:48:25.656 +08:00] [INFO] [coordinator.go:319] ["Coordinator is stopping"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [labeler.go:69] ["region labeler GC stopped"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [etcdutil.go:612] ["server is closed, exit watch loop"] [name=scheduling-region-label-watcher] [key=/pd/7263376508257569687/region_label]
[2023/08/04 16:48:25.656 +08:00] [INFO] [server.go:639] ["got signal to exit"] [signal=interrupt]
[2023/08/04 16:48:25.656 +08:00] [INFO] [coordinator.go:141] ["patrol regions has been stopped"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [register.go:73] ["exit register process"] [key=/ms/7263376508257569687/scheduling/registry/http://127.0.0.1:3379]
[2023/08/04 16:48:25.656 +08:00] [INFO] [server.go:258] ["closing scheduling server ..."]
[2023/08/04 16:48:25.656 +08:00] [INFO] [etcdutil.go:612] ["server is closed, exit watch loop"] [name=scheduling-rule-watcher] [key=/pd/7263376508257569687/rules]
[2023/08/04 16:48:25.656 +08:00] [INFO] [lease.go:184] ["stop lease keep alive worker"] [purpose="primary election"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [etcdutil.go:612] ["server is closed, exit watch loop"] [name=scheduling-config-watcher] [key=/pd/7263376508257569687/config]
[2023/08/04 16:48:25.656 +08:00] [INFO] [coordinator.go:243] ["check suspect key ranges has been stopped"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [coordinator.go:307] ["drive push operator has been stopped"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [coordinator.go:322] ["Coordinator has been stopped"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [server.go:245] ["server is closed"]
[2023/08/04 16:48:25.656 +08:00] [INFO] [etcdutil.go:612] ["server is closed, exit watch loop"] [name=scheduling-rule-group-watcher] [key=/pd/7263376508257569687/rule_group]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:179] ["server is closed, exit resource manager primary election loop"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:414] ["stopping http server"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:401] ["mux stopped serving"] [error="accept tcp 127.0.0.1:3379: use of closed network connection"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:364] ["http server stopped"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:436] ["http server stopped"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:439] ["stopping grpc server"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:351] ["grpc server stopped"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:473] ["grpc server stopped"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [etcdutil.go:273] ["[etcd client] etcd client is closed, exit health check goroutine"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [etcdutil.go:316] ["[etcd client] etcd client is closed, exit update endpoint goroutine"]
[2023/08/04 16:48:25.657 +08:00] [INFO] [server.go:275] ["scheduling server is closed"]

Check List

Tests

  • Manual test (see above logs)

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch August 4, 2023 08:01
@rleungx rleungx removed the request for review from nolouch August 4, 2023 08:02
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #6896 (a3a41ef) into master (c98f6da) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 65.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6896      +/-   ##
==========================================
+ Coverage   74.38%   74.40%   +0.02%     
==========================================
  Files         427      427              
  Lines       45226    45243      +17     
==========================================
+ Hits        33641    33663      +22     
+ Misses       8632     8626       -6     
- Partials     2953     2954       +1     
Flag Coverage Δ
unittests 74.40% <65.62%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx changed the title *: remove some store config *: make coordinator run Aug 4, 2023
@rleungx rleungx requested a review from JmPotato August 4, 2023 08:50
@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 7, 2023
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 7, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2023
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Aug 10, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d30aa24

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2023
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2023
@rleungx
Copy link
Member Author

rleungx commented Aug 10, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 2d9fab8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 3554a34 into tikv:master Aug 10, 2023
21 of 23 checks passed
@rleungx rleungx deleted the remove-some-store-config branch August 10, 2023 10:18
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants