Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: sync store config in time (#6919) #6933

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6919

What problem does this PR solve?

Issue Number: Close #6918

What is changed and how does it work?

add timeout context for observer tikv config to avoid wait too long

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

sync store config in time

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx August 10, 2023 05:35
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2023
Signed-off-by: bufferflies <[email protected]>
@bufferflies bufferflies force-pushed the cherry-pick-6919-to-release-7.1 branch from 3bfa2aa to 9a5b924 Compare August 11, 2023 03:50
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 88.42% and project coverage change: -0.09% ⚠️

Comparison is base (f8bf1d7) 74.96% compared to head (887002e) 74.87%.
Report is 4 commits behind head on release-7.1.

❗ Current head 887002e differs from pull request most recent head ebf0dcb. Consider uploading reports for the commit ebf0dcb to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #6933      +/-   ##
===============================================
- Coverage        74.96%   74.87%   -0.09%     
===============================================
  Files              406      406              
  Lines            40755    40834      +79     
===============================================
+ Hits             30551    30574      +23     
- Misses            7539     7577      +38     
- Partials          2665     2683      +18     
Flag Coverage Δ
unittests 74.87% <88.42%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/errs/errno.go 100.00% <ø> (ø)
client/resource_group/controller/config.go 87.50% <ø> (ø)
client/resource_group/controller/limiter.go 72.06% <ø> (ø)
client/resource_group/controller/testutil.go 100.00% <ø> (ø)
pkg/schedule/placement/fit.go 94.94% <0.00%> (-1.08%) ⬇️
server/config/store_config.go 77.98% <66.66%> (-2.42%) ⬇️
pkg/schedule/operator/create_operator.go 91.07% <72.72%> (-0.71%) ⬇️
pkg/schedule/checker/rule_checker.go 83.00% <76.92%> (-0.69%) ⬇️
client/resource_group/controller/controller.go 73.60% <100.00%> (-0.05%) ⬇️
pkg/schedule/operator/builder.go 86.68% <100.00%> (+0.08%) ⬆️
... and 7 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2023
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 11, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 11, 2023

@bufferflies: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies bufferflies force-pushed the cherry-pick-6919-to-release-7.1 branch from b130574 to 887002e Compare August 11, 2023 08:51
Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 28, 2023
@nolouch
Copy link
Contributor

nolouch commented Aug 28, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ebf0dcb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2023
@rleungx
Copy link
Member

rleungx commented Aug 29, 2023

/test build

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

@rleungx: No presubmit jobs available for tikv/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

@purelind: No presubmit jobs available for tikv/[email protected]

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/test build

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

@purelind: No presubmit jobs available for tikv/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/test build

@tikv tikv deleted a comment from ti-chi-bot bot Aug 29, 2023
@tikv tikv deleted a comment from ti-chi-bot bot Aug 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4bcd2ab into tikv:release-7.1 Aug 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants