client: add backoff for member loop
#6995
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| // Copyright 2023 TiKV Project Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package retry | ||
|
|
||
| import ( | ||
| "context" | ||
| "time" | ||
|
|
||
| "github.com/pingcap/failpoint" | ||
| ) | ||
|
|
||
| // BackOffer is a backoff policy for retrying operations. | ||
| type BackOffer struct { | ||
| maxBackoff time.Duration | ||
| nextBackoff time.Duration | ||
| initialBackoff time.Duration | ||
| } | ||
|
|
||
| // WithBackoff is a helper function to add backoff. | ||
| func WithBackoff( | ||
| ctx context.Context, | ||
| fn func() error, | ||
| bo *BackOffer, | ||
| ) error { | ||
| if err := fn(); err != nil { | ||
| select { | ||
| case <-ctx.Done(): | ||
| case <-time.After(bo.NextBackoff()): | ||
| failpoint.Inject("backOffExecute", func() { | ||
| testBackOffExecuteFlag = true | ||
| }) | ||
| } | ||
| return err | ||
| } | ||
| // Reset backoff when fn() succeed. | ||
| bo.ResetBackoff() | ||
| return nil | ||
| } | ||
|
|
||
| // InitialBackOffer make the initial state for retrying. | ||
| func InitialBackOffer(initialBackoff, maxBackoff time.Duration) BackOffer { | ||
| return BackOffer{ | ||
| maxBackoff: maxBackoff, | ||
| initialBackoff: initialBackoff, | ||
| nextBackoff: initialBackoff, | ||
| } | ||
| } | ||
|
|
||
| // NextBackoff implements the `Backoffer`, for now use the `ExponentialBackoff`. | ||
| func (rs *BackOffer) NextBackoff() time.Duration { | ||
| return rs.exponentialBackoff() | ||
| } | ||
|
|
||
| // exponentialBackoff Get the exponential backoff duration. | ||
HuSharp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| func (rs *BackOffer) exponentialBackoff() time.Duration { | ||
|
There was a problem hiding this comment. Will we use exponential backoff by default? When network partition a long time, it may need more time to recover. There was a problem hiding this comment. limited by max backoff time... |
||
| backoff := rs.nextBackoff | ||
| rs.nextBackoff *= 2 | ||
| if rs.nextBackoff > rs.maxBackoff { | ||
| rs.nextBackoff = rs.maxBackoff | ||
| } | ||
| return backoff | ||
| } | ||
|
|
||
| // ResetBackoff reset the backoff to initial state. | ||
| func (rs *BackOffer) ResetBackoff() { | ||
| rs.nextBackoff = rs.initialBackoff | ||
| } | ||
|
|
||
| // Only used for test. | ||
| var testBackOffExecuteFlag = false | ||
|
|
||
| // TestBackOffExecute Only used for test. | ||
| func TestBackOffExecute() bool { | ||
| return testBackOffExecuteFlag | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // Copyright 2023 TiKV Project Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package retry | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/pingcap/errors" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestExponentialBackoff(t *testing.T) { | ||
| re := require.New(t) | ||
|
|
||
| baseBackoff := 100 * time.Millisecond | ||
| maxBackoff := 1 * time.Second | ||
|
|
||
| backoff := InitialBackOffer(baseBackoff, maxBackoff) | ||
| re.Equal(backoff.NextBackoff(), baseBackoff) | ||
| re.Equal(backoff.NextBackoff(), 2*baseBackoff) | ||
|
|
||
| for i := 0; i < 10; i++ { | ||
| re.LessOrEqual(backoff.NextBackoff(), maxBackoff) | ||
| } | ||
| re.Equal(backoff.NextBackoff(), maxBackoff) | ||
|
|
||
| // Reset backoff | ||
| backoff.ResetBackoff() | ||
| err := WithBackoff(context.Background(), func() error { | ||
| return errors.New("test") | ||
| }, &backoff) | ||
| re.Error(err) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lhy1024 for
member loopmax backup time time is1 secondwhich isupdateMemberTimeout, PTAL, thx!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.