Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add a switch to dynamically enable scheduling service #7595

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 20, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR adds a switch to dynamically enable scheduling service. If we only upgrade the scheduling service, the logic could be different from the logic inside the api service. To avoid the changes of different logic bringing some troubles, we use a config to let the users control it by themselves.

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2023
@rleungx rleungx requested review from lhy1024 and CabinfeverB and removed request for HunDunDM December 20, 2023 07:47
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #7595 (cb367e7) into master (6472313) will increase coverage by 0.01%.
The diff coverage is 51.42%.

❗ Current head cb367e7 differs from pull request most recent head ee9014b. Consider uploading reports for the commit ee9014b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7595      +/-   ##
==========================================
+ Coverage   73.72%   73.73%   +0.01%     
==========================================
  Files         429      429              
  Lines       47498    47503       +5     
==========================================
+ Hits        35018    35027       +9     
+ Misses       9498     9486      -12     
- Partials     2982     2990       +8     
Flag Coverage Δ
unittests 73.73% <51.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I think there's a little bit of learning cost to using this configuration

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2023
@CabinfeverB
Copy link
Member

I test it by pd-ctl

Before
image

config set enable-dynamic-switch "false"

After
image

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2024
@rleungx
Copy link
Member Author

rleungx commented Jan 15, 2024

change to enable-scheduling-fallback

Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Jan 17, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

This pull request has been accepted and is ready to merge.

Commit hash: cb367e7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit af84465 into tikv:master Jan 17, 2024
22 checks passed
@rleungx rleungx deleted the add-switch branch January 17, 2024 06:50
rleungx added a commit to rleungx/pd that referenced this pull request Jan 25, 2024
* etcdutil, mcs: fix the issue loading label rules is too slow (tikv#7718)

Signed-off-by: lhy1024 <[email protected]>

* ci: run `make check` with longer timeout (tikv#7271)

ref tikv#4399

Signed-off-by: lhy1024 <[email protected]>

* mcs: add a switch to dynamically enable scheduling service (tikv#7595)

ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* schedule: prevent suddenly scheduling (tikv#7714)

ref tikv#7671

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* makefile: update golangci (tikv#7556)

close tikv#7551

Signed-off-by: husharp <[email protected]>

* fix conflict

Signed-off-by: lhy1024 <[email protected]>

---------

Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: husharp <[email protected]>
Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: Hu# <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants