-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: add a switch to dynamically enable scheduling service #7595
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7595 +/- ##
==========================================
+ Coverage 73.72% 73.73% +0.01%
==========================================
Files 429 429
Lines 47498 47503 +5
==========================================
+ Hits 35018 35027 +9
+ Misses 9498 9486 -12
- Partials 2982 2990 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I think there's a little bit of learning cost to using this configuration
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
change to |
Signed-off-by: Ryan Leung <[email protected]>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: cb367e7
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
* etcdutil, mcs: fix the issue loading label rules is too slow (tikv#7718) Signed-off-by: lhy1024 <[email protected]> * ci: run `make check` with longer timeout (tikv#7271) ref tikv#4399 Signed-off-by: lhy1024 <[email protected]> * mcs: add a switch to dynamically enable scheduling service (tikv#7595) ref tikv#5839 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * schedule: prevent suddenly scheduling (tikv#7714) ref tikv#7671 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * makefile: update golangci (tikv#7556) close tikv#7551 Signed-off-by: husharp <[email protected]> * fix conflict Signed-off-by: lhy1024 <[email protected]> --------- Signed-off-by: lhy1024 <[email protected]> Signed-off-by: husharp <[email protected]> Co-authored-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: Hu# <[email protected]>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
This PR adds a switch to dynamically enable scheduling service. If we only upgrade the scheduling service, the logic could be different from the logic inside the api service. To avoid the changes of different logic bringing some troubles, we use a config to let the users control it by themselves.
Check List
Tests
Release note