*: simplify raft cluster. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func (s *testClusterCacheSuite) SetUpSuite(c *C) { | ||
| s.svr = newTestServer(c, s.getRootPath()) | ||
|
|
| // cluster 1 -> /raft/1, value is metapb.Cluster | ||
| // cluster 2 -> /raft/2 | ||
| // cluster 1 -> /1/raft, value is metapb.Cluster | ||
| // cluster 2 -> /1/raft |
There was a problem hiding this comment.
The comment should be /2/raft?
|
LGTM |
| @@ -21,6 +21,7 @@ var ( | |||
| leaderLease = flag.Int64("lease", 3, "Leader lease time (second)") | |||
| logLevel = flag.String("L", "debug", "log level: info, debug, warn, error, fatal") | |||
| pprofAddr = flag.String("pprof", ":6060", "pprof HTTP listening address") | |||
| clusterID = flag.Uint64("cluster-id", 0, "Cluster ID") | |||
There was a problem hiding this comment.
Maybe another default clusterID since 0 is for test.
There was a problem hiding this comment.
check 0 and panic?
There was a problem hiding this comment.
I think make the default value to be 1 is enough.
There was a problem hiding this comment.
em, 1 seems strange, I prefer 0 if 1.
We can log a warning if we use 0. Btw for most cases, we use different root path not "/pd", so it is ok.
|
LGTM |
|
PTAL @ngaut |
|
LGTM |
lhy1024
pushed a commit
to lhy1024/pd
that referenced
this pull request
May 17, 2023
* added get region by keyspace api Signed-off-by: David <[email protected]> * fix encoding Signed-off-by: David <[email protected]> * addd pd-ctl Signed-off-by: David <[email protected]> * change description Signed-off-by: David <[email protected]> * change pd-ctl command to add id Signed-off-by: David <[email protected]> * check keyspace id before fetch Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Signed-off-by: lhy1024 <[email protected]>
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jun 5, 2023
* added get region by keyspace api Signed-off-by: David <[email protected]> * fix encoding Signed-off-by: David <[email protected]> * addd pd-ctl Signed-off-by: David <[email protected]> * change description Signed-off-by: David <[email protected]> * change pd-ctl command to add id Signed-off-by: David <[email protected]> * check keyspace id before fetch Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #68
@ngaut @qiuyesuifeng @disksing