*: fix client log #8060
*: fix client log #8060
Conversation
Signed-off-by: Ryan Leung <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XS
| @@ -465,7 +465,7 @@ func (c *tsoServiceDiscovery) updateMember() error { | |||
| oldGroupID := c.GetKeyspaceGroupID() | |||
| if oldGroupID != keyspaceGroup.Id { | |||
| log.Info("[tso] the keyspace group changed", | |||
| zap.Uint32("keyspace-id", keyspaceGroup.Id), | |||
| zap.Uint32("keyspace-id", keyspaceID), | |||
There was a problem hiding this comment.
Is it necessary to use keyspace-id-in-request as in the code above?
There was a problem hiding this comment.
It's unnecessary because it might be printed after finishing the request.
|
/merge |
|
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 8c4ff5b
|
ti-chi-bot
bot
added
the
status/can-merge
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8060 +/- ##
==========================================
- Coverage 77.33% 77.33% -0.01%
==========================================
Files 468 468
Lines 60943 60942 -1
==========================================
- Hits 47133 47132 -1
Misses 10256 10256
Partials 3554 3554 |
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
Check List
Tests
Release note