-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add prow OWNERS files to control the approvals for critical configuration files #8218
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @wuhuizuo. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bfc13bb
to
7d8d6e0
Compare
/hold let @wuhuizuo to decide when to merge it. |
@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: easonn7, kevin-xianliu, niubell. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8218 +/- ##
==========================================
+ Coverage 77.29% 77.41% +0.11%
==========================================
Files 471 471
Lines 61377 61369 -8
==========================================
+ Hits 47441 47507 +66
+ Misses 10373 10305 -68
+ Partials 3563 3557 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
a285f03
to
e00160b
Compare
@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: easonn7, kevin-xianliu, niubell. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
b565a1e
to
2a8a19b
Compare
/unhold |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2a8a19b
|
/cherry-pick release-8.1 |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…nfiguration files (#8218) (#8252) close #8167 Signed-off-by: wuhuizuo <[email protected]> Co-authored-by: wuhuizuo <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
…nfiguration files (#8218) (#8250) close #8167 Signed-off-by: wuhuizuo <[email protected]> Co-authored-by: wuhuizuo <[email protected]>
…nfiguration files (#8218) (#8249) close #8167 Signed-off-by: wuhuizuo <[email protected]> Co-authored-by: wuhuizuo <[email protected]>
…nfiguration files (#8218) (#8248) close #8167 Signed-off-by: wuhuizuo <[email protected]> Co-authored-by: wuhuizuo <[email protected]> Co-authored-by: husharp <[email protected]>
…nfiguration files (#8218) (#8251) close #8167 Signed-off-by: wuhuizuo <[email protected]> Co-authored-by: wuhuizuo <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Close #8167
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note