Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: persist region leader #8238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

*: persist region leader #8238

wants to merge 2 commits into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 3, 2024

What problem does this PR solve?

Issue Number: ref #7897.

What is changed and how does it work?

Before:
Screenshot 2024-06-07 at 10 15 56
Screenshot 2024-06-07 at 10 16 11

After:
Screenshot 2024-06-07 at 10 17 24
Screenshot 2024-06-07 at 10 17 33

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and nolouch June 3, 2024 06:58
Signed-off-by: Ryan Leung <[email protected]>
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (199b017) to head (4371db4).
Report is 54 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8238      +/-   ##
==========================================
+ Coverage   77.26%   77.38%   +0.11%     
==========================================
  Files         471      471              
  Lines       61346    61346              
==========================================
+ Hits        47401    47474      +73     
+ Misses      10383    10311      -72     
+ Partials     3562     3561       -1     
Flag Coverage Δ
unittests 77.38% <85.29%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch
Copy link
Contributor

nolouch commented Sep 26, 2024

Do we still consider this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants