Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add more comments about scheduler redirect #8279

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jun 12, 2024

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

Check List

Tests

  • No code

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2024
@lhy1024 lhy1024 requested a review from rleungx June 12, 2024 10:13
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (c015f14) to head (b2d087e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8279      +/-   ##
==========================================
+ Coverage   77.36%   77.44%   +0.08%     
==========================================
  Files         471      471              
  Lines       61383    61383              
==========================================
+ Hits        47487    47539      +52     
+ Misses      10346    10292      -54     
- Partials     3550     3552       +2     
Flag Coverage Δ
unittests 77.44% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 12, 2024
@rleungx rleungx added require-LGT1 Indicates that the PR requires an LGTM. and removed approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2024
@rleungx
Copy link
Member

rleungx commented Jun 12, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-12 10:27:03.97480618 +0000 UTC m=+546778.028118105: ☑️ agreed by rleungx.
  • 2024-06-12 12:30:32.058626015 +0000 UTC m=+554186.111937939: ☑️ agreed by HuSharp.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 12, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

@lhy1024: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024 lhy1024 removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 12, 2024
@HuSharp
Copy link
Member

HuSharp commented Jun 12, 2024

/LGTM

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

@HuSharp: Your lgtm message is repeated, so it is ignored.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 12, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

@lhy1024: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HuSharp HuSharp added the lgtm label Jun 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9348164 into tikv:master Jun 12, 2024
20 checks passed
@lhy1024 lhy1024 deleted the mcs-comments branch June 12, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants