Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: check if the endpoint has been removed before evicting #8287

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #8286.

What is changed and how does it work?

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jun 14, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.36%. Comparing base (13174b5) to head (cd92a5b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8287      +/-   ##
==========================================
+ Coverage   77.25%   77.36%   +0.11%     
==========================================
  Files         470      470              
  Lines       61385    61387       +2     
==========================================
+ Hits        47423    47494      +71     
+ Misses      10401    10331      -70     
- Partials     3561     3562       +1     
Flag Coverage Δ
unittests 77.36% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-14 06:48:04.830038225 +0000 UTC m=+706438.883350149: ☑️ agreed by nolouch.
  • 2024-06-14 09:31:13.764386036 +0000 UTC m=+716227.817697960: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit 463aee9 into tikv:master Jun 14, 2024
20 checks passed
@HuSharp
Copy link
Member

HuSharp commented Jun 14, 2024

/run-cherry-picker

@JmPotato JmPotato deleted the fix_evicted_ep branch June 14, 2024 14:28
@JmPotato JmPotato added type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8290.

@JmPotato JmPotato added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jun 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8291.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2024
…) (#8290)

close #8286

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2024
…) (#8291)

close #8286

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The removed member should no longer appear in the list of evicted endpoints
5 participants