-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdutil: check if the endpoint has been removed before evicting #8287
Conversation
Signed-off-by: JmPotato <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8287 +/- ##
==========================================
+ Coverage 77.25% 77.36% +0.11%
==========================================
Files 470 470
Lines 61385 61387 +2
==========================================
+ Hits 47423 47494 +71
+ Misses 10401 10331 -70
- Partials 3561 3562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, nolouch, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
…) (#8290) close #8286 Once a member is removed from the cluster, its endpoint should no longer exist in the health checker. This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly. Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
…) (#8291) close #8286 Once a member is removed from the cluster, its endpoint should no longer exist in the health checker. This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly. Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
What problem does this PR solve?
Issue Number: close #8286.
What is changed and how does it work?
Check List
Tests
Release note