Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "*: enlarge the default value of max-merge-region-size. (#8445)" #8541

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

LykxSassinator
Copy link
Contributor

This reverts commit aa85b6c.

What problem does this PR solve?

Issue Number: Ref pingcap/tidb#55374

What is changed and how does it work?

Revert the changes on the configuration of region-size. These changes will be delayed until v8.4.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@LykxSassinator
Copy link
Contributor Author

/test

Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2024

@LykxSassinator: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LykxSassinator
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 16, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.43%. Comparing base (248206b) to head (3ec6a99).
Report is 1 commits behind head on release-8.3.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.3    #8541      +/-   ##
===============================================
+ Coverage        77.41%   77.43%   +0.01%     
===============================================
  Files              473      473              
  Lines            61933    61933              
===============================================
+ Hits             47946    47955       +9     
- Misses           10406    10410       +4     
+ Partials          3581     3568      -13     
Flag Coverage Δ
unittests 77.43% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-16 04:21:36.576814737 +0000 UTC m=+500981.280284395: ☑️ agreed by nolouch.
  • 2024-08-16 07:00:20.696965368 +0000 UTC m=+510505.400435011: ☑️ agreed by lhy1024.

Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024, niubell, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8b35fcd into tikv:release-8.3 Aug 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants