Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support configuring tso switch #8755

Merged
merged 13 commits into from
Nov 6, 2024
Merged

*: support configuring tso switch #8755

merged 13 commits into from
Nov 6, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 31, 2024

What problem does this PR solve?

Issue Number: Close #8477.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (cfd8f34) to head (d97bdd2).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8755      +/-   ##
==========================================
- Coverage   75.58%   75.57%   -0.01%     
==========================================
  Files         461      461              
  Lines       72275    72285      +10     
==========================================
+ Hits        54627    54631       +4     
- Misses      14145    14149       +4     
- Partials     3503     3505       +2
Flag Coverage Δ
unittests 75.57% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 31, 2024
JmPotato
JmPotato reviewed Nov 1, 2024
View reviewed changes
tests/integrations/mcs/tso/server_test.go Outdated
tsoCluster.WaitForDefaultPrimaryServing(re)

// Wait for TSO server to start and PD to detect it
time.Sleep(300 * time.Millisecond)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make it a Eventually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/integrations/mcs/tso/server_test.go Outdated
Comment on lines 626 to 636
// Verify PD is not providing TSO service
err = checkTSOMonotonic(ctx, pdClient, &globalLastTS, 10)
re.NoError(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could this guarantee that the PD is not providing TSO service?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the allocator now

@rleungx
Copy link
Member Author

rleungx commented Nov 1, 2024

/hold I set config to true temporarily for the test.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2024
@rleungx rleungx requested a review from JmPotato November 1, 2024 08:51
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-31 07:18:38.674173966 +0000 UTC m=+507031.513329675: ☑️ agreed by lhy1024.
  • 2024-11-04 07:44:57.551082571 +0000 UTC m=+854210.390238114: ☑️ agreed by JmPotato.

@rleungx
support configuring tso switch
34de1f2 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
fix lint
e70dd8f 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
global
0246448 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
enable
81cc314 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
make test stable
976466a 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
fixt
4ea4959 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
fix
ffe8f81 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
address the comment
34178a4 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
tiny changes
d499646 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
tiny changes
f0413eb 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
fix
01df01f 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
change back to false
fc62075 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Nov 5, 2024

/retest

@rleungx
Copy link
Member Author

rleungx commented Nov 5, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@rleungx
Copy link
Member Author

rleungx commented Nov 5, 2024

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Nov 5, 2024

/retest

@rleungx
Copy link
Member Author

rleungx commented Nov 5, 2024

@niubell PTAL

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit b27f021 into tikv:master Nov 6, 2024
25 checks passed
@rleungx rleungx deleted the tso-test branch November 6, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@niubell niubell niubell approved these changes

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support switching TSO service dynamically
4 participants
@rleungx @JmPotato @niubell @lhy1024