Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: support setting float for qps #8787

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 7, 2024

What problem does this PR solve?

Issue Number: Ref #5739

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.56%. Comparing base (39575d2) to head (6e2465b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8787      +/-   ##
==========================================
- Coverage   75.69%   75.56%   -0.14%     
==========================================
  Files         461      461              
  Lines       72298    72304       +6     
==========================================
- Hits        54729    54639      -90     
- Misses      14078    14158      +80     
- Partials     3491     3507      +16     
Flag Coverage Δ
unittests 75.56% <63.63%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested a review from lhy1024 November 7, 2024 09:24
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 09:34:40.677513612 +0000 UTC m=+1119993.516669158: ☑️ agreed by okJiang.
  • 2024-11-07 11:22:32.276467441 +0000 UTC m=+1126465.115622988: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit c9e532c into tikv:master Nov 8, 2024
23 of 25 checks passed
@rleungx rleungx deleted the support-qps-float branch November 8, 2024 05:57
@rleungx rleungx added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 8, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #8797.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants