Move protos to a separate crate #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Raft a workspace project Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
BusyJay
reviewed
Jun 19, 2019
|
|
||
| [dependencies] | ||
| bytes = "0.4.11" | ||
| lazy_static = "1.3.0" |
There was a problem hiding this comment.
Why does it depend on lazy_static?
There was a problem hiding this comment.
Some of the rust-protobuf API we are emulating requires an initialised default with static lifetime, lazy_static is the best way to support that.
There was a problem hiding this comment.
Interesting. It may also be the reason why it doesn't perform as expected.
There was a problem hiding this comment.
Could const fn help solve it one day?
There was a problem hiding this comment.
Maybe, I'm not sure. I hope we can just eliminate uses of that wrapper function and then remove lazy static
BusyJay
approved these changes
Jun 19, 2019
Hoverbear
approved these changes
Jun 19, 2019
Hoverbear
added
Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Raft a workspace project
Motivated by pingcap/kvproto#280
PTAL @Hoverbear @BusyJay