Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process high pri request with mutex in rate limiter #375

Closed
wants to merge 1 commit into from
Closed

Process high pri request with mutex in rate limiter #375

wants to merge 1 commit into from

Conversation

v01dstar
Copy link

The existing code has concurrency problem. Some of the fields should be processed with lock held.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Sep 24, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@wuhuizuo
Copy link

/lgtm

refresh

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wuhuizuo
Once this PR has been reviewed and has the lgtm label, please assign spadea-tang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@v01dstar v01dstar mentioned this pull request Sep 25, 2024
Open
@v01dstar v01dstar marked this pull request as draft September 25, 2024 20:48
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@v01dstar
Copy link
Author

I tested this change with benchbot, no regression.

@v01dstar v01dstar closed this Oct 9, 2024
@v01dstar v01dstar deleted the fix-rate-limiter branch October 9, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpadeA-Tang SpadeA-Tang Awaiting requested review from SpadeA-Tang

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v01dstar @wuhuizuo