Titan followup changes #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
v01dstar
force-pushed
the
titan-followup
branch
6 times, most recently
from
be2a999
to
a68a6d1
Compare
Connor1996
approved these changes
Oct 8, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
titan-followup
branch
from
a68a6d1
to
7247f11
Compare
LykxSassinator
approved these changes
Oct 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/run-all-tests |
v01dstar
added a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Yang Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueType0x10 tokTypeTitanColumnFamilyBlobIndexand 0x11 tokTypeTitanBlobIndex, and addWriteBatchInternal::PutTitanBlobIndex()for Titan to use.StatisticsImplimplementation from statistics.cc to statistics_impl.h. Template code should be in header files instead of cc files, otherwise, there will beundefined symbolerror while linking.Maintainer's note:
When upgrading RocksDB in the future, we need to check all the occurrence of
kTypeBlobIndexandkTypeColumnFamilyBlobIndex(for blob indices in non-default cf) in RocksDB's repo, and addkTypeTitanBlobIndexandkTypeTitanColumnFamilyBlobIndexaccordingly. AnywherekTypeColumnFamilyBlobIndexexists, we need to addkTypeTitanColumnFamilyBlobIndex, wherekTypeBlobIndexexists, we need to addkTypeTitanBlobIndex.