-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add abort-on-panic
config (#10164)
#10216
*: Add abort-on-panic
config (#10164)
#10216
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@yiwu-arbug you're already a collaborator in bot's repo. |
Signed-off-by: Yi Wu <[email protected]>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@yiwu-arbug: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: fca113b
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@yiwu-arbug: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #10164 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/10216
After apply modifications, you can push your change to this PR via:
Signed-off-by: Yi Wu [email protected]
What problem does this PR solve?
Problem Summary:
abort-on-panic
to allow TiKV generate a core dump. This is useful when core dump is desire to investigate issues.What is changed and how it works?
What's Changed: Add the above two configs.
Related changes
pingcap/docs
/pingcap/docs-cn
: will send PR later.Check List
Tests
Manually test the flows
Release note
abort-on-panic
config, which allow core dump to be generated when panic. Users still need to correctly config the environment to enable core dump.