Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add abort-on-panic config (#10164) #10216

Merged
merged 4 commits into from
May 26, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 20, 2021

cherry-pick #10164 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/10216

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tikv.git pr/10216:release-5.0-421e6e068c20

Signed-off-by: Yi Wu [email protected]

What problem does this PR solve?

Problem Summary:

  • Add a config abort-on-panic to allow TiKV generate a core dump. This is useful when core dump is desire to investigate issues.
  • Adding message in panic_mark_file fatal log to warn users not to delete the panic_mark_file and force restart.
  • Adding a warning when tikv-ctl encounter rocksdb LOCK file conflict, which warns user not to delete the LOCK file.

What is changed and how it works?

What's Changed: Add the above two configs.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: will send PR later.
  • Need to cherry-pick to the release branch: release-5.0

Check List

Tests
Manually test the flows

Release note

  • Add abort-on-panic config, which allow core dump to be generated when panic. Users still need to correctly config the environment to enable core dump.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels May 20, 2021
@ti-srebot ti-srebot requested a review from Connor1996 May 20, 2021 00:44
@ti-srebot ti-srebot added this to the v5.0.2 milestone May 20, 2021
@ti-srebot
Copy link
Contributor Author

@yiwu-arbug you're already a collaborator in bot's repo.

Signed-off-by: Yi Wu <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2021
@yiwu-arbug
Copy link

/test

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • yiwu-arbug

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 20, 2021
@yiwu-arbug
Copy link

/merge

@ti-chi-bot
Copy link
Member

@yiwu-arbug: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fca113b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 26, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yiwu-arbug
Copy link

/merge

@ti-chi-bot
Copy link
Member

@yiwu-arbug: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 57b098f into tikv:release-5.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants