-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check stale file information and remove Rename operation in encryption module #10598
Conversation
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 413a782
|
@hunterlxt: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Xintao [email protected]
cherry-pick #9285 to release-4.0
What problem does this PR solve?
Issue Number: close #9115
Problem Summary:
This PR is to solve the stale information encountered in the encryption dictionary
delete_file
onfile_dict
, the stale information leavesdst_fname
is added to the dictionary file, but the realrename
is not successful or executerename
but failed to deletesrc_fname
dst_fname
is added to the dictionary file, the subsequent operations don't finish.In the above situation, some stale file information will appear in the encrypted file dictionary. We need to deal with these errors instead of generating and returning errors.
What is changed and how it works?
Proposal: xxx
What's Changed:
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Side effects
Release note