Revert "*: make unified-pool use FuturePool (#15925)"

[nolouch]

This reverts commit 7be1b17.

What is changed and how it works?

Issue Number: Close #16015

What's Changed:

Revert "*: make unified-pool use FuturePool (#15925)"
- revert due to performance regression

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression
  • Consumes more CPU
  • Consumes more MEM
• Breaking backward compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bufferflies
• glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[nolouch]

/hold

[nolouch]

/release

[sre-bot]

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/c6cfecb2318889f82380f3a582934d5dcc4f4aa1/centos7/tikv-server.tar.gz

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nolouch]

/unhold

[sre-bot]

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/c6cfecb2318889f82380f3a582934d5dcc4f4aa1/centos7/tikv-server.tar.gz

[nolouch]

Benchmark with sysbench oltp_point_select in 3 high performance machines:

Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                72
On-line CPU(s) list:   0-71
Thread(s) per core:    2
Core(s) per socket:    18
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 85
Model name:            Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz
Stepping:              7
CPU MHz:               3900.000
CPU max MHz:           3900.0000
CPU min MHz:           1000.0000
BogoMIPS:              5200.00
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              1024K
L3 cache:              25344K
NUMA node0 CPU(s):     0-17,36-53
NUMA node1 CPU(s):     18-35,54-71
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke avx512_vnni md_clear flush_l1d arch_capabilities

TiKV: 3* 16c 48GB Memory

Command:

sysbench oltp_point_select run --mysql-host=tidb-dsn.perftest-component-check-001-tps-5251026-1-128 --mysql-port=4000 --mysql-user=root --db-driver=mysql --mysql-db=test --threads=100 --time=600 --report-interval=10 --tables=32 --table-size=10000000 --mysql-ignore-errors=1062,2013,8028,9002,9007 --auto-inc=false

Base

hash 1819bb8f077aba4f4a28eb0aa89d43fcd3f873d7:

result:

SQL statistics:                                                                                                                                 │··········································································································································
    queries performed:                                                                                                                          │··········································································································································
        read:                            128135121                                                                                              │··········································································································································
        write:                           0                                                                                                      │··········································································································································
        other:                           0                                                                                                      │··········································································································································
        total:                           128135121                                                                                              │··········································································································································
    transactions:                        128135121 (213554.33 per sec.)                                                                         │··········································································································································
    queries:                             128135121 (213554.33 per sec.)                                                                         │··········································································································································
    ignored errors:                      0      (0.00 per sec.)                                                                                 │··········································································································································
    reconnects:                          0      (0.00 per sec.)                                                                                 │··········································································································································
                                                                                                                                                │··········································································································································
General statistics:                                                                                                                             │··········································································································································
    total time:                          600.0105s                                                                                              │··········································································································································
    total number of events:              128135121                                                                                              │··········································································································································
                                                                                                                                                │··········································································································································
Latency (ms):                                                                                                                                   │··········································································································································
         min:                                    0.18                                                                                           │··········································································································································
         avg:                                    0.47                                                                                           │··········································································································································
         max:                                  214.99                                                                                           │··········································································································································
         95th percentile:                        0.65                                                                                           │··········································································································································
         sum:                             59954380.22                                                                                           │··········································································································································
                                                                                                                                                │··········································································································································
Threads fairness:                                                                                                                               │··········································································································································
    events (avg/stddev):           1281351.2100/52471.59                                                                                        │··········································································································································
    execution time (avg/stddev):   599.5438/0.02                                                                                                │··········································································································································
                                                 

Bad PR :

hash: 7be1b17d72870bb95fcb7443b1f945f9c59657fa

SQL statistics:                                                                                                                                 │··········································································································································
    queries performed:                                                                                                                          │··········································································································································
        read:                            125242650                                                                                              │··········································································································································
        write:                           0                                                                                                      │··········································································································································
        other:                           0                                                                                                      │··········································································································································
        total:                           125242650                                                                                              │··········································································································································
    transactions:                        125242650 (208733.50 per sec.)                                                                         │··········································································································································
    queries:                             125242650 (208733.50 per sec.)                                                                         │··········································································································································
    ignored errors:                      0      (0.00 per sec.)                                                                                 │··········································································································································
    reconnects:                          0      (0.00 per sec.)                                                                                 │··········································································································································
                                                                                                                                                │··········································································································································
General statistics:                                                                                                                             │··········································································································································
    total time:                          600.0109s                                                                                              │··········································································································································
    total number of events:              125242650                                                                                              │··········································································································································
                                                                                                                                                │··········································································································································
Latency (ms):                                                                                                                                   │··········································································································································
         min:                                    0.17                                                                                           │··········································································································································
         avg:                                    0.48                                                                                           │··········································································································································
         max:                                  231.83                                                                                           │··········································································································································
         95th percentile:                        0.69                                                                                           │··········································································································································
         sum:                             59956408.02                                                                                           │··········································································································································
                                                                                                                                                │··········································································································································
Threads fairness:                                                                                                                               │··········································································································································
    events (avg/stddev):           1252426.5000/76790.31                                                                                        │··········································································································································
    execution time (avg/stddev):   599.5641/0.03                                                                                                │··········································································································································
                                                   

This PR:

result

SQL statistics:                                                                                                                                 │··········································································································································
    queries performed:                                                                                                                          │··········································································································································
        read:                            128335038                                                                                              │··········································································································································
        write:                           0                                                                                                      │··········································································································································
        other:                           0                                                                                                      │··········································································································································
        total:                           128335038                                                                                              │··········································································································································
    transactions:                        128335038 (213887.42 per sec.)                                                                         │··········································································································································
    queries:                             128335038 (213887.42 per sec.)                                                                         │··········································································································································
    ignored errors:                      0      (0.00 per sec.)                                                                                 │··········································································································································
    reconnects:                          0      (0.00 per sec.)                                                                                 │··········································································································································
                                                                                                                                                │··········································································································································
General statistics:                                                                                                                             │··········································································································································
    total time:                          600.0108s                                                                                              │··········································································································································
    total number of events:              128335038                                                                                              │··········································································································································
                                                                                                                                                │··········································································································································
Latency (ms):                                                                                                                                   │··········································································································································
         min:                                    0.17                                                                                           │··········································································································································
         avg:                                    0.47                                                                                           │··········································································································································
         max:                                  305.91                                                                                           │··········································································································································
         95th percentile:                        0.64                                                                                           │··········································································································································
         sum:                             59956242.92                                                                                           │··········································································································································
                                                                                                                                                │··········································································································································
Threads fairness:                                                                                                                               │··········································································································································
    events (avg/stddev):           1283350.3800/16773.28                                                                                        │··········································································································································
    execution time (avg/stddev):   599.5624/0.02 

[nolouch]

PTAL @glorv @bufferflies

[bufferflies]

Suggested change

	"The number of running threads in the unified read pool",
	"The number of running tasks in the unified read pool",

maybe pending task is more readable.

[nolouch]

Its threads in here.

[bufferflies]

/merge

[ti-chi-bot]

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 1642e33

[ti-chi-bot]

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.