Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "*: enlarge the default region-size. (#17311)" #17389

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Revert "*: enlarge the default region-size. (#17311)" #17389

merged 2 commits into from
Aug 16, 2024

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Aug 16, 2024 •
edited
Loading

This reverts commit 74a760f.

What is changed and how it works?

Issue Number: Ref pingcap/tidb#55374

What's Changed:

Revert the changes on the configuration of region-size. These changes will be delayed until v8.4

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 16, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-16 04:16:51.007600649 +0000 UTC m=+500695.711070310: ☑️ agreed by SpadeA-Tang.
  • 2024-08-16 04:20:24.949661736 +0000 UTC m=+500909.653131378: ☑️ agreed by glorv.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2024
@LykxSassinator
Copy link
Contributor Author

/approve

1 similar comment
@zhangjinpeng87
Copy link
Member

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, LykxSassinator, SpadeA-Tang, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit a4c0ea1 into tikv:release-8.3 Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpadeA-Tang SpadeA-Tang SpadeA-Tang approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LykxSassinator @zhangjinpeng87 @glorv @SpadeA-Tang @ti-chi-bot