expr/builtin_fncall: implement MultiplyIntUnsigned #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! BTW I saw "MultiplyIntUnsigned" occurred in multiple places. Since we are already using macros, can we just eliminate it to one place to be more friendly to the contributor? |
|
Would you pull the request for it @breeswish ? |
|
@AndreMouche Love to! |
XuHuaiyu
approved these changes
Jul 3, 2018
|
/run-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
This PR implements the scalar function MultiplyIntUnsigned
What are the type of the changes? (mandatory)
The currently defined types are listed below, please pick one of the types for this PR by removing the others:
How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
#3275
The related source in tidb: https://github.com/pingcap/tidb/blob/master/expression/builtin_arithmetic.go#L532
@zz-jason @XuHuaiyu @breeswish PTAL