-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore/hibernate: wake up on proposal #6736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added
sig/raft
Component: Raft, RaftStore, etc.
type/bugfix
This PR fixes a bug.
labels
Feb 28, 2020
5kbpers
approved these changes
Feb 28, 2020
BusyJay
added
needs-cherry-pick-release-3.0
Type: Need cherry pick to release 3.0
needs-cherry-pick-release-3.1
Type: Need cherry pick to release 3.1
labels
Feb 28, 2020
I think the fail case is probably fixed by #6648. |
gengliqi
approved these changes
Feb 28, 2020
BusyJay
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 28, 2020
/run-all-tests |
cherry pick to release-3.0 failed |
cherry pick to release-3.1 failed |
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
Merged
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Feb 28, 2020
Signed-off-by: Jay Lee <[email protected]>
youjiali1995
pushed a commit
that referenced
this pull request
Feb 29, 2020
Signed-off-by: Jay Lee <[email protected]>
youjiali1995
pushed a commit
that referenced
this pull request
Feb 29, 2020
solotzg
pushed a commit
to pingcap/tidb-engine-ext
that referenced
this pull request
Feb 29, 2020
* raftstore/hibernate: wake up for more cases (tikv#6672) * raftstore/hibernate: wake up on proposal (tikv#6736) Signed-off-by: Jay Lee <[email protected]>
solotzg
pushed a commit
to pingcap/tidb-engine-ext
that referenced
this pull request
Feb 29, 2020
* raftstore/hibernate: wake up for more cases (tikv#6672) * raftstore/hibernate: wake up on proposal (tikv#6736) Signed-off-by: Jay Lee <[email protected]>
zhangjinpeng87
pushed a commit
to zhangjinpeng87/tikv
that referenced
this pull request
Mar 26, 2020
Signed-off-by: Jay Lee <[email protected]>
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: Jay Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-3.0
Type: Need cherry pick to release 3.0
needs-cherry-pick-release-3.1
Type: Need cherry pick to release 3.1
sig/raft
Component: Raft, RaftStore, etc.
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
#6672 breaks hibernate regions by not waking leader up on proposal accidentally. This PR fixes by setting all the missing flags.
What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect
tidb-ansible
?No.
Refer to a related PR or issue link (optional)
#6672