cdc: fix old value config glitch when changefeeds with different settings connect to one region (#9515) #9565
Conversation
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
component/CDC
|
@liuzix please accept the invitation then you can push to the cherry-pick pull requests. |
ti-chi-bot
added
size/XXL
|
/run-all-tests |
ti-chi-bot
added
size/L
Signed-off-by: Zixiong Liu <[email protected]>
liuzix
force-pushed
the
release-4.0-927e36f952f8
branch
from
2250c9a
to
f629c06
Compare
Signed-off-by: Zixiong Liu <[email protected]>
|
/cc @leoppro |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/run-all-tests |
|
/merge |
|
@NingLin-P: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 6f7fecf
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
@NingLin-P: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…ings connect to one region (tikv#9515) (tikv#9565) cherry-pick tikv#9515 to release-4.0 You can switch your code base to this Pull Request by using [git-extras](https://github.com/tj/git-extras): ```bash # In tikv repo: git pr tikv#9565 ``` After apply modifications, you can push your change to this PR via: ```bash git push [email protected]:ti-srebot/tikv.git pr/9565:release-4.0-927e36f952f8 ``` --- <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed If you want to open the **Challenge Program** pull request, please use the following template: https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md --> ### What problem does this PR solve? Problem Summary: When two TiCDC changefeeds connect to the same region, but one changefeed requires old value but the other doesn't, the one that doesn't need old value still receives old value. ### What is changed and how it works? What's Changed: Now we record the old value setting in each `Downstream` and filters the old value appropriately before sinking the events. ### Related changes - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test ### Release note <!-- bugfixes or new feature need a release note --> - Fix old value config glitch when changefeeds with different settings connect to one region
cherry-pick #9515 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/9565After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
When two TiCDC changefeeds connect to the same region, but one changefeed requires old value but the other doesn't, the one that doesn't need old value still receives old value.
What is changed and how it works?
What's Changed: Now we record the old value setting in each
Downstreamand filters the old value appropriately before sinking the events.Related changes
Check List
Tests
Release note