server: add server info metrics for DBasS (#9582) #9591

ti-srebot · 2021-01-28T02:36:07Z

cherry-pick #9582 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/9591

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tikv.git pr/9591:release-4.0-0fe01b8da4b8

Signed-off-by: iosmanthus [email protected]

What problem does this PR solve?

This pull request adds server info metrics via a GaugeVec in format: (version, githash) -> startup_ts.

Problem Summary:

Related changes

Need to cherry-pick to the release branch

Check List

Tests

Manual test (add detailed scripts or steps below)

http get 'http://localhost:9090/api/datasources/proxy/1/api/v1/query_range?query=tikv_server_info&start=1611738330&end=1611738465&step=15'

{
    "data": {
        "result": [
            {
                "metric": {
                    "__name__": "tikv_server_info",
                    "hash": "None",
                    "instance": "127.0.0.1:20180",
                    "job": "tikv",
                    "version": "5.0.0-rc.x"
                },
                "values": [
                    [
                        1611738360,
                        "1611738218"
                    ],
                    [
                        1611738375,
                        "1611738218"
                    ],
                    [
                        1611738390,
                        "1611738218"
                    ],
                    [
                        1611738405,
                        "1611738218"
                    ]
                ]
            }
        ],
        "resultType": "matrix"
    },
    "status": "success"
}

Side effects

Performance regression
- Consumes more CPU
- Consumes more MEM
Breaking backward compatibility

Release note

server: add server info metrics for DBasS

Signed-off-by: ti-srebot <[email protected]>

ti-srebot · 2021-01-28T02:36:10Z

/run-all-tests

ti-srebot · 2021-01-28T02:36:19Z

@iosmanthus please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tikv/invitations

Signed-off-by: iosmanthus <[email protected]>

breezewish · 2021-01-28T05:54:28Z

/lgtm

zhongzc · 2021-01-28T06:02:40Z

/lgtm

ti-chi-bot · 2021-01-28T06:02:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

breeswish
zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

zhongzc · 2021-01-28T06:02:47Z

/merge

ti-chi-bot · 2021-01-28T06:02:47Z

@zhongzc: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-01-28T06:02:49Z

This pull request has been accepted and is ready to merge.

Commit hash: 36c5c24

NingLin-P · 2021-01-28T06:04:26Z

/merge

ti-chi-bot · 2021-01-28T06:04:27Z

@NingLin-P: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-01-28T06:04:29Z

@NingLin-P: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-01-28T06:04:34Z

@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

cherry-pick tikv#9582 to release-4.0 You can switch your code base to this Pull Request by using [git-extras](https://github.com/tj/git-extras): ```bash # In tikv repo: git pr tikv#9591 ``` After apply modifications, you can push your change to this PR via: ```bash git push [email protected]:ti-srebot/tikv.git pr/9591:release-4.0-0fe01b8da4b8 ``` --- Signed-off-by: iosmanthus <[email protected]> ### What problem does this PR solve? This pull request adds server info metrics via a `GaugeVec` in format: `(version, githash) -> startup_ts`. Problem Summary: ### Related changes - Need to cherry-pick to the release branch ### Check List  Tests  - Manual test (add detailed scripts or steps below) ```sh http get 'http://localhost:9090/api/datasources/proxy/1/api/v1/query_range?query=tikv_server_info&start=1611738330&end=1611738465&step=15' { "data": { "result": [ { "metric": { "__name__": "tikv_server_info", "hash": "None", "instance": "127.0.0.1:20180", "job": "tikv", "version": "5.0.0-rc.x" }, "values": [ [ 1611738360, "1611738218" ], [ 1611738375, "1611738218" ], [ 1611738390, "1611738218" ], [ 1611738405, "1611738218" ] ] } ], "resultType": "matrix" }, "status": "success" } ``` Side effects - Performance regression - Consumes more CPU - Consumes more MEM - Breaking backward compatibility ### Release note  - server: add server info metrics for DBasS

cherry pick tikv#9582 to release-4.0

46af467

Signed-off-by: ti-srebot <[email protected]>

ti-srebot mentioned this pull request Jan 28, 2021

server: add server info metrics for DBasS #9582

Merged

ti-srebot added component/server Component: Server sig/diagnosis SIG: Diagnosis size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels Jan 28, 2021

ti-srebot requested review from breezewish and zhongzc January 28, 2021 02:36

ti-srebot added this to the v4.0.11 milestone Jan 28, 2021

ti-srebot assigned iosmanthus Jan 28, 2021

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2021

fix conflicts

36c5c24

Signed-off-by: iosmanthus <[email protected]>

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2021

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 28, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2021

Merge branch 'release-4.0' into release-4.0-0fe01b8da4b8

348c4bd

ti-chi-bot merged commit e4fbabf into tikv:release-4.0 Jan 28, 2021

NingLin-P mentioned this pull request Feb 1, 2021

releases: add tidb v4.0.11 release notes pingcap/docs#4761

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server: add server info metrics for DBasS (#9582) #9591

server: add server info metrics for DBasS (#9582) #9591

ti-srebot commented Jan 28, 2021 •

edited

Loading

ti-srebot commented Jan 28, 2021

ti-srebot commented Jan 28, 2021

breezewish commented Jan 28, 2021

zhongzc commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

zhongzc commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

NingLin-P commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

server: add server info metrics for DBasS (#9582) #9591

server: add server info metrics for DBasS (#9582) #9591

Conversation

ti-srebot commented Jan 28, 2021 • edited Loading

What problem does this PR solve?

Related changes

Check List

Release note

ti-srebot commented Jan 28, 2021

ti-srebot commented Jan 28, 2021

breezewish commented Jan 28, 2021

zhongzc commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

zhongzc commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

NingLin-P commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-chi-bot commented Jan 28, 2021

ti-srebot commented Jan 28, 2021 •

edited

Loading