Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command palette #1160

Merged
merged 38 commits into from
Feb 7, 2024
Merged

Add command palette #1160

merged 38 commits into from
Feb 7, 2024

Conversation

yohannd1
Copy link
Contributor

@yohannd1 yohannd1 commented Jun 15, 2023

Attempt to add a command palette to furnace, to potentially facilitate finding specific actions and improve keyboard-only usage.

For more info, see this github discussion and this discord thread.

Right now this is quite an early version, though. Feel free to critique this as the design is still very fluid.

2023-06-15.01-38-46.mp4

Checklist

  • Make basic implementation
  • Decide on how the window should appear (centered on top like VsCode/Atom? following the mouse?)
  • Add submenus
    • Recent files
    • Select instrument
    • Select sample
    • Change instrument in selection
    • Add chip
  • Improve display names (some actions do not have a full description)

won't be doing for wavetables because they don't have text and that
would be impossible to search through with a keyboard
@freq-mod
Copy link
Collaborator

freq-mod commented Dec 6, 2023

Is it still being worked on?

@yohannd1
Copy link
Contributor Author

yohannd1 commented Dec 7, 2023

Yes, but kinda slowly. I haven't had much time&motivation to work on this lately.
It's almost finished, though. I think I was just going to rename some actions.

@yohannd1 yohannd1 marked this pull request as ready for review December 18, 2023 19:08
@yohannd1
Copy link
Contributor Author

yohannd1 commented Feb 3, 2024

Hello! I thought I had finished this around 2 months ago (hence me marking it as ready for review), but I realized I forgot to rename a few things.
So I did that now, along with keeping it up to date with the master branch. Now it's 100% ready for review!

Copy link
Owner

@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have accidentally changed the fmt submodule...
Please set it to the commit that upstream Furnace uses.

Copy link
Owner

@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Check out these two review comments.

src/gui/commandPalette.h Outdated Show resolved Hide resolved
src/gui/commandPalette.cpp Outdated Show resolved Hide resolved
src/gui/commandPalette.cpp Outdated Show resolved Hide resolved
src/gui/commandPalette.cpp Outdated Show resolved Hide resolved
@tildearrow tildearrow self-assigned this Feb 5, 2024
@yohannd1
Copy link
Contributor Author

yohannd1 commented Feb 5, 2024

Quick fix! Forgot that instrument numbers should be displayed as hexadecimal, so changed it in the code from %02d to %02x.

Copy link
Owner

@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Will test later, but for now merging.

@tildearrow tildearrow merged commit a6aa4b6 into tildearrow:master Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants