Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Window #1623

Merged
merged 10 commits into from
Dec 22, 2023
Merged

Export Window #1623

merged 10 commits into from
Dec 22, 2023

Conversation

Eknous-P
Copy link
Contributor

@Eknous-P Eknous-P commented Dec 5, 2023 •
edited
Loading

puts all the export types and their configurations in a separate modal popup window

todo: align the cancel button to the bottom done

@Eknous-P
dummy export window, keybind and related settings
df63257
@Eknous-P
the export types
b90132d 
wtf is settings.iCannotWait ???
@Eknous-P
put the types in a child
d2ca97c 
now the cancel button is neatly at the bottom :)
@Eknous-P Eknous-P marked this pull request as ready for review December 5, 2023 14:14
tildearrow
tildearrow requested changes Dec 5, 2023
View reviewed changes
Copy link
Owner

@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename exportWin.cpp to exportOptions.cpp

@Eknous-P
Copy link
Contributor Author

Eknous-P commented Dec 6, 2023

i just noticed
the window can be activated with the shortcut even if settings.classicExportOptions is true
is that okay?
and should the default value of that setting be changed?

@tildearrow
Copy link
Owner

i just noticed the window can be activated with the shortcut even if settings.classicExportOptions is true is that okay? and should the default value of that setting be changed?

Yeah, should be fine since it allows keyboard binding.

tildearrow
tildearrow requested changes Dec 7, 2023
View reviewed changes
src/gui/exportOptions.cpp Outdated Show resolved Hide resolved
@tildearrow
Copy link
Owner

Will review in a couple hours hopefully

tildearrow
tildearrow requested changes Dec 21, 2023
View reviewed changes
Copy link
Owner

@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic export options not implemented.

@Eknous-P
Copy link
Contributor Author

what? how?

@tildearrow
Copy link
Owner

what? how?

If they are, then there's some code duplication.... I'll fix that in a while.

@tildearrow tildearrow self-assigned this Dec 22, 2023
@tildearrow
Copy link
Owner

Thanks for the work. I will finish the rest and then merge.

@tildearrow tildearrow merged commit a642cb4 into tildearrow:master Dec 22, 2023
3 checks passed
@Eknous-P Eknous-P deleted the exportwin branch December 22, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tildearrow tildearrow tildearrow requested changes

Assignees

@tildearrow tildearrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eknous-P @tildearrow