Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid messages logged to console #281

Open
robbytx opened this issue Feb 17, 2019 · 0 comments
Open

Invalid messages logged to console #281

robbytx opened this issue Feb 17, 2019 · 0 comments

Comments

@robbytx
Copy link

robbytx commented Feb 17, 2019

Upon upgrading to Ember 3.7.x, I found that the JavaScript console had strange messages being logged from this library, like:

Transition #Attempting URL transition to /myroute/123: undefined
Preparing to transition from '' to 'myroute'
0
Transitioned into 'myroute'
0

The 1st, 3rd, and 5th, messages all seem to stem from an incorrect check in the log function at:
https://github.com/tildeio/router.js/blob/master/lib/router/utils.ts#L74

I think if (arguments.length === 2) should be replaced with if (args.length === 2).

vincent99 added a commit to vincent99/router.js that referenced this issue Feb 20, 2019
chadhietala added a commit that referenced this issue Feb 21, 2019
[BUGFIX] Incorrect logging of messages with sequence numbers (#281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant