We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upon upgrading to Ember 3.7.x, I found that the JavaScript console had strange messages being logged from this library, like:
Transition #Attempting URL transition to /myroute/123: undefined Preparing to transition from '' to 'myroute' 0 Transitioned into 'myroute' 0
The 1st, 3rd, and 5th, messages all seem to stem from an incorrect check in the log function at: https://github.com/tildeio/router.js/blob/master/lib/router/utils.ts#L74
log
I think if (arguments.length === 2) should be replaced with if (args.length === 2).
if (arguments.length === 2)
if (args.length === 2)
The text was updated successfully, but these errors were encountered:
Fix logging of messages with sequence numbers (tildeio#281)
174a00c
Merge pull request #282 from vincent99/master
c315882
[BUGFIX] Incorrect logging of messages with sequence numbers (#281)
No branches or pull requests
Upon upgrading to Ember 3.7.x, I found that the JavaScript console had strange messages being logged from this library, like:
The 1st, 3rd, and 5th, messages all seem to stem from an incorrect check in the
log
function at:https://github.com/tildeio/router.js/blob/master/lib/router/utils.ts#L74
I think
if (arguments.length === 2)
should be replaced withif (args.length === 2)
.The text was updated successfully, but these errors were encountered: