Upgrade CI #311
Merged
Upgrade CI #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stefanpenner
commented
Nov 6, 2020
stefanpenner
commented
- use volta
- test across multiple node versions and OS's
- run tests weekly on sundays to catch odd things
* use volta * test across multiple node versions and OS's * run tests weekly on sundays to catch odd things
stefanpenner
force-pushed
the
update-ci
branch
from
e39697c
to
dd12c9c
Compare
rwjblue
reviewed
Nov 9, 2020
Comment on lines
+21
to
+22
| node: ['10', '12', '14', '15'] | ||
| os: [ubuntu-latest, macOS-latest, windows-latest] |
There was a problem hiding this comment.
FWIW, I don't think this provides any value. All of our tests run in the browser which is the same across all of these matrix setups...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.