fix: jsx attributes with a 'null' value

tim-richter · Aug 7, 2024 · 2495bca · 2495bca
1 parent 920c15e
commit 2495bca
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 2 deletions.
diff --git a/src/features/report/index.test.ts b/src/features/report/index.test.ts
@@ -263,6 +263,45 @@ describe("scanAST", () => {
     `);
   });
 
+  it('should handle props with "null" syntax', () => {
+    const code = `
+export const Code = ({ title, files, deps }: CodeProps) => {
+  return (
+    <SandpackCodeEditor wrapContent />
+  )
+}
+`
+    const ast = scanAST({ code, filePath: "src/test/Component.tsx" });
+
+    expect(ast).toMatchInlineSnapshot(`
+      {
+        "components": [
+          {
+            "location": {
+              "end": {
+                "column": 23,
+                "line": 4,
+              },
+              "start": {
+                "column": 5,
+                "line": 4,
+              },
+            },
+            "name": "SandpackCodeEditor",
+            "props": [
+              {
+                "name": "wrapContent",
+                "value": true,
+              },
+            ],
+            "propsSpread": false,
+          },
+        ],
+        "filePath": "src/test/Component.tsx",
+      }
+    `)
+  })
+
   it("should parse literal values from JSXExpressionContainers", () => {
     const code = `
       import { Button } from 'my-library';

diff --git a/src/features/report/index.ts b/src/features/report/index.ts
@@ -71,7 +71,9 @@ const getComponentNameFromAST = (
   return nameObj.name;
 };
 
-function getPropValue(node: TSESTree.JSXExpression | TSESTree.Literal) {
+function getPropValue(node: TSESTree.JSXExpression | TSESTree.Literal | null) {
+  if (!node) return true;
+
   if (node.type === "Literal") {
     return node.value;
   }

diff --git a/src/features/report/scan.ts b/src/features/report/scan.ts
@@ -10,7 +10,7 @@ export const scan = (crawlFrom: string) => {
     .glob(...globs)
     .withRelativePaths()
     .exclude((dirName) =>
-      dirName.startsWith("node_modules") || dirName.startsWith('.')  
+      dirName.startsWith("node_modules") || dirName.startsWith('.') || dirName.startsWith('dist') 
     )
     .crawl(crawlFrom)
     .sync();