Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pgx to 0.5.4. #589

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Update pgx to 0.5.4. #589

merged 2 commits into from
Oct 21, 2022

Conversation

epgts
Copy link
Contributor

@epgts epgts commented Oct 20, 2022

This has various fixes for RHEL derivatives (centos 7 and Rocky 8).

@epgts
Update pgx to 0.5.3.
0bc93ea 
This has various fixes for RHEL derivatives (centos 7 and Rocky 8).
@epgts epgts requested review from syvb and WireBaron October 20, 2022 17:03
@epgts
Copy link
Contributor Author

epgts commented Oct 20, 2022

Behold! A tested centos 7 build: https://github.com/timescale/release-build-scripts/actions/runs/3291079352/jobs/5424777115

syvb
syvb approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@syvb syvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to revert fe8b386 now that a memory issue was fixed in pgx. That can be a separate PR though.

workingjubilee
workingjubilee reviewed Oct 21, 2022
View reviewed changes
Copy link

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today's fix of pgcentralfoundation/pgrx#795 is unfortunately probably important to also have, my apologies.

extension/Cargo.toml Outdated Show resolved Hide resolved
extension/Cargo.toml Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
docker/ci/setup.sh Outdated Show resolved Hide resolved
@bompi88
Copy link

bompi88 commented Oct 21, 2022

Today's fix of tcdi/pgx#795 is unfortunately probably important to also have, my apologies.

I agree. We also need 0.5.4.

@epgts
Update pgx to 0.5.4.
d74382f 
More bugs fixed!
@epgts epgts changed the title Update pgx to 0.5.3. Update pgx to 0.5.4. Oct 21, 2022
@epgts
Copy link
Contributor Author

epgts commented Oct 21, 2022

Today's fix of tcdi/pgx#795 is unfortunately probably important to also have, my apologies.

No apologies necessary! Thanks for all the quick fixes! :)

@epgts
Copy link
Contributor Author

epgts commented Oct 21, 2022

bors r+

@epgts epgts mentioned this pull request Oct 21, 2022
Merged
@bors
Copy link
Contributor

bors bot commented Oct 21, 2022

Build succeeded:

@bors bors bot merged commit 2fe2ac8 into main Oct 21, 2022
@bors bors bot deleted the eg/pgx-0.5.3 branch October 21, 2022 23:32
@rtwalker rtwalker mentioned this pull request Oct 21, 2022
Merged
@syvb syvb mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

@WireBaron WireBaron WireBaron approved these changes

@syvb syvb syvb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@epgts @bompi88 @syvb @WireBaron @workingjubilee