Add timeline_agg #636
Merged
Add timeline_agg #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/state_agg-more
branch
from
9d0ed0f
to
fb8da95
Compare
syvb
changed the title
This was referenced Nov 28, 2022
WireBaron
reviewed
Dec 1, 2022
WireBaron
reviewed
Dec 1, 2022
| #[derive(Clone, Debug, Deserialize, Eq, FlatSerializable, PartialEq, Serialize)] | ||
| #[repr(C)] | ||
| pub struct TimeInState { | ||
| start_time: i64, |
There was a problem hiding this comment.
minor nitpick, but it seems a bit wasteful to be always storing this when, for every value but the first, it will be the same as the end_time for the previous value.
|
|
||
| #[derive(Clone, Debug, Deserialize, Eq, FlatSerializable, PartialEq, Serialize)] | ||
| #[repr(C)] | ||
| pub struct DurationInState { | ||
| duration: i64, // TODO BRIAN is i64 or u64 the right type | ||
| duration: i64, | ||
| state_beg: u32, |
There was a problem hiding this comment.
We really should be able to store an array of strings in the same order as their duration information, though we don't currently have a flat serializable implementation for this. Even with that we'd have to store some index in each TimeInState though, which would have to take up 64 bytes to be aligned, so it's not a big win.
WireBaron
approved these changes
Dec 5, 2022
syvb
force-pushed
the
sv/state_agg-more
branch
from
4997c37
to
327e22e
Compare
epgts
approved these changes
Dec 6, 2022
syvb
force-pushed
the
sv/state_agg-more
branch
from
327e22e
to
33dc255
Compare
|
bors r+ |
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Dec 6, 2022
640: Support rollup and integer states state/timeline aggs r=Smittyvb a=Smittyvb - Adds `rollup` for `state_agg` and `timeline_agg`. - Supports integer states for `state_agg` and `timeline_agg`. An aggregate can have integer states or string states, but not both. For a few functions this would mean having two functions with the same argument types but differing return types, so in that case I made a separate function for integer-valued aggregates (e.g. `state_int_timeline`). Ideally this should have been two separate PRs, but my changes to `rollup` and the rest of the `state_agg` code have become intertwined. (this should be merged after #636) Co-authored-by: Smitty <[email protected]> Co-authored-by: Smittyvb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
timeline_aggaggregate that can be used in the same ways asstate_aggbut also allows getting the entire state timeline withstate_timeline.Note that this PR returns start times and end times instead of
tstzranges. pgx 0.6.0 will add support fortstzranges so when that release comes out I'll update the relevant functions to return ranges.This partially addresses #619 (adding
rollupand supporting integer values will be separate PRs to make them easier to review).