Fix errors in state_agg rollup #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/state_agg-rollup-errors
branch
from
373b299
to
94557c2
Compare
WireBaron
reviewed
Feb 22, 2023
syvb
force-pushed
the
sv/state_agg-rollup-errors
branch
from
4337e96
to
2189720
Compare
Signed-off-by: Smittyvb <[email protected]>
WireBaron
approved these changes
Feb 23, 2023
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix out-of-bounds indexing in
rollup:last_statein the merged aggregate was computed incorrectly; it is now determined correctlyIt also improves the various error messages that could arise when using rollup.