Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start 1.16.0-dev #727

Closed
wants to merge 1 commit into from
Closed

start 1.16.0-dev #727

wants to merge 1 commit into from

Conversation

svenklemm
Copy link
Member

No description provided.

syvb
syvb approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@syvb syvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the release script to use the github-actions[bot] user for these automated PRs in the future (using secrets.GITHUB_TOKEN instead of secrets.API_TOKEN_GITHUB_PACKAGE for the part that creates this PR).

@jerryxwu
Copy link
Contributor

jerryxwu commented Mar 9, 2023

bors+

@syvb
Copy link
Member

syvb commented Mar 9, 2023

Looks like the upgrade tests failed:

tests/update/time-weighted-average.md:45 `Time Weighted Average Tests`::`Test integral and interpolated integral`

SELECT integral(agg, 'hrs') FROM twa;

Error: output has a different values than expected.
Expected
200
 60
550
(3 rows)

Received
625
100
220
(3 rows)

Delta
-200+625
 -60+100
-550+220

@jerryxwu
Copy link
Contributor

jerryxwu commented Mar 9, 2023 •
edited
Loading

@thatzopoulos Has the behaviour of integral and interpolated_integral changed at all in 1.15.0?

@WireBaron WireBaron mentioned this pull request Mar 10, 2023
Merged
@thatzopoulos thatzopoulos mentioned this pull request Mar 10, 2023
Merged
bors bot added a commit that referenced this pull request Mar 10, 2023
@bors @thatzopoulos
Merge #734
930bd54 
734: Fix failing update test r=WireBaron a=thatzopoulos

Fixes for the failing update test that is holding back #727

Co-authored-by: Thomas Hatzopoulos <[email protected]>
@WireBaron
Copy link
Contributor

Resubmitted this as #737

@WireBaron WireBaron closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syvb syvb syvb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svenklemm @jerryxwu @syvb @WireBaron