Change parameter name to enable Hypercore TAM #7411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7411 +/- ##
==========================================
+ Coverage 80.06% 82.56% +2.49%
==========================================
Files 190 229 +39
Lines 37181 42731 +5550
Branches 9450 10731 +1281
==========================================
+ Hits 29770 35279 +5509
- Misses 2997 3168 +171
+ Partials 4414 4284 -130 ☔ View full report in Codecov by Sentry. |
mkindahl
force-pushed
the
hypercore-use_access_method
branch
5 times, most recently
from
e1d53bc
to
22aa0fa
Compare
mkindahl
force-pushed
the
hypercore-use_access_method
branch
2 times, most recently
from
3faae59
to
0dfefaa
Compare
kpan2034
approved these changes
Oct 31, 2024
erimatnor
approved these changes
Nov 4, 2024
Yes, I think so. All user-facing parameters should be coordinated. Will fix. |
mkindahl
force-pushed
the
hypercore-use_access_method
branch
from
45c1e8b
to
159ea80
Compare
Done. |
mkindahl
force-pushed
the
hypercore-use_access_method
branch
from
159ea80
to
39b2556
Compare
mkindahl
force-pushed
the
hypercore-use_access_method
branch
from
39b2556
to
a83c471
Compare
Changing from using the `compress_using` parameter with a table access method name to use the boolean parameter `hypercore_use_access_method` instead to avoid having to provide a name when using the table access method for compression.
mkindahl
force-pushed
the
hypercore-use_access_method
branch
from
a83c471
to
623270b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from using the
compress_usingparameter with a table access method name to use the boolean parameterhypercore_use_access_methodinstead to avoid having to provide a name when using the table access method for compression.