Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failure in upstream test jsonb_jsonpath #7419

Merged

Conversation

pallavisontakke
Copy link
Contributor

@pallavisontakke pallavisontakke commented Nov 6, 2024

Until PG 17.1 is released.

Currently shows a diff in PG 17.0 regression run as:

select jsonb_path_query_tz('"12:34:56"', '$.time_tz().string()');
  jsonb_path_query_tz
 ---------------------
- "12:34:56-07:00"
+ "12:34:56-08:00"

Disable-check: force-changelog-file

Until PG 17.1 is released.

Currently shows a diff in regression as:

select jsonb_path_query_tz('"12:34:56"', '$.time_tz().string()');
  jsonb_path_query_tz
 ---------------------
- "12:34:56-07:00"
+ "12:34:56-08:00"
Copy link

github-actions bot commented Nov 6, 2024

@fabriziomello, @akuzm: please review this pull request.

Powered by pull-review

@pallavisontakke pallavisontakke requested review from akuzm and svenklemm and removed request for akuzm November 6, 2024 11:36
@pallavisontakke pallavisontakke self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (59f50f2) to head (c955c9b).
Report is 574 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7419      +/-   ##
==========================================
+ Coverage   80.06%   82.57%   +2.50%     
==========================================
  Files         190      229      +39     
  Lines       37181    42740    +5559     
  Branches     9450    10739    +1289     
==========================================
+ Hits        29770    35293    +5523     
- Misses       2997     3160     +163     
+ Partials     4414     4287     -127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pallavisontakke pallavisontakke merged commit fc2805e into timescale:main Nov 6, 2024
50 of 55 checks passed
@pallavisontakke pallavisontakke deleted the ignore_upstream_test branch November 6, 2024 12:47
@akuzm akuzm added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label Nov 6, 2024
@timescale-automation
Copy link

Automated backport to 2.17.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.17.x
You are currently cherry-picking commit fc2805ecd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/pgtest/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) backported-2.17.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants