Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom documentation in README could be clarified. #135

Closed
kmsquire opened this issue Feb 5, 2020 · 6 comments
Closed

Zoom documentation in README could be clarified. #135

kmsquire opened this issue Feb 5, 2020 · 6 comments

Comments

@kmsquire
Copy link
Contributor

kmsquire commented Feb 5, 2020

Beyond the title, I'm not sure what else to say.

If I get some time, I'll try to debug further, but I don't know when that might be, so for now, this is mostly a flag.

@timholy
Copy link
Owner

timholy commented Feb 5, 2020

Have you tried all the modifiers?

I see the docs are also a bit misleading: it's really CTRL-click-drag to select a zoom region via a rubber band.

@kmsquire
Copy link
Contributor Author

kmsquire commented Feb 5, 2020

I did try all the modifiers, but did not try dragging. Will try that when I get in front of a computer.

@kmsquire kmsquire changed the title Zoom not functional on Mac Zoom documentation in README could be clarified. Feb 5, 2020
@kmsquire
Copy link
Contributor Author

kmsquire commented Feb 5, 2020

Ctrl-click + dragging works!

After some experimenting, most of the other things work too. I can't check the right click -> edit functionality (I don't have a mouse handy right now, and the macbook trackpad only has one button).

What doesn't seem to work (for me):

  • A double click does not reset the view
  • Ctrl + shift + arrow keys don't do anything (nor do other modifiers work)

For that last one, there's a always a chance that the keystrokes are being captured by something else before they get to the window. I couldn't find anything that set those, but it's a bit tedious to try to find them, so I could have missed something.

So it's likely that only the double click doesn't seem to work, which can be worked around that by zooming with ctrl-scroll (ctrl-swipe).

I'll make an MR that clarifies the documentation.

kmsquire added a commit to kmsquire/ProfileView.jl that referenced this issue Feb 5, 2020
It wasn't clear from the readme that dragging was needed after CTRL-clicking.

Also clarified some of the other language, and noted things that don't seem to work on Macs.
@timholy
Copy link
Owner

timholy commented Feb 5, 2020

I can't check the right click

Right click should be equivalent to two-finger tap: https://www.cnet.com/how-to/five-ways-to-right-click-on-a-mac-trackpad/

A double click does not reset the view

Hmm, looking at the docs, it would have been hard to be less clear...hold down the Ctrl key while you do it.

Ctrl + shift + arrow keys don't do anything (nor do other modifiers work)

You're right. Here we suffer from the fact that it's almost impossible to write tests for GUIs. Can you file as a separate bug?

@kmsquire
Copy link
Contributor Author

kmsquire commented Feb 5, 2020

Hmm, looking at the docs, it would have been hard to be less clear...hold down the Ctrl key while you do it.

:-) Will update #136 again.

@kmsquire
Copy link
Contributor Author

kmsquire commented Feb 5, 2020

Ctrl + shift + arrow keys don't do anything (nor do other modifiers work)

You're right. Here we suffer from the fact that it's almost impossible to write tests for GUIs. Can you file as a separate bug?

Sure. Just to clarify, is this Mac-only, or are you seeing this on Linux as well? (I think I remember that you're a Linux user...)

kmsquire added a commit to kmsquire/ProfileView.jl that referenced this issue Feb 5, 2020
* It wasn't clear from the readme that dragging was needed after CTRL-clicking.
* Also clarified some of the other language, and noted things that don't seem to work on Macs.
kmsquire added a commit to kmsquire/ProfileView.jl that referenced this issue Feb 5, 2020
* It wasn't clear from the readme that dragging was needed after CTRL-clicking.
* Also clarified some of the other language.
kmsquire added a commit to kmsquire/ProfileView.jl that referenced this issue Feb 5, 2020
* It wasn't clear from the readme that dragging was needed after CTRL-clicking.
* Also clarified some of the other language.
kmsquire added a commit to kmsquire/ProfileView.jl that referenced this issue Feb 8, 2020
* It wasn't clear from the readme that dragging was needed after CTRL-clicking.
* Also clarified some of the other language.
* Removed the text stating that the user can use their keyboard to pan.  It
  doesn't seem to work on Mac, and probably not Linux.  It's unclear if it
  works on Windows.
kmsquire added a commit to kmsquire/ProfileView.jl that referenced this issue Feb 8, 2020
* It wasn't clear from the readme that dragging was needed after CTRL-clicking.
* Also clarified some of the other language.
* Removed the text stating that the user can use their keyboard to pan.  It
  doesn't seem to work on Mac, and probably not Linux.  It's unclear if it
  works on Windows.
@timholy timholy closed this as completed in 9e62a15 Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants