Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an info popup and zoom buttons #188

Merged
merged 4 commits into from
Jan 16, 2022

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Jan 15, 2022

See the new i icon here.

I wanted to add a colored legend too, but the flamegraph colors are dynamic, and showing colors in a gtk popup would take some work.

Screenshot from 2022-01-15 15-28-26

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #188 (e2b7fa5) into master (c048a49) will decrease coverage by 2.56%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   80.99%   78.43%   -2.57%     
==========================================
  Files           2        2              
  Lines         221      255      +34     
==========================================
+ Hits          179      200      +21     
- Misses         42       55      +13     
Impacted Files Coverage Δ
src/ProfileView.jl 84.74% <66.66%> (-3.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c048a49...e2b7fa5. Read the comment docs.

@IanButterworth
Copy link
Collaborator Author

I tried to add a test for this, but I can't find a way to programmatically close a Gtk.info_dialog given that the function doesn't return until the user clicks "OK". A timed async destroy might have worked, but felt a bit ugly for testing

@IanButterworth
Copy link
Collaborator Author

Also added:

  • Zoom buttons
  • Toolbar spacers
  • Tooltips on the toolbar buttons

Screen Shot 2022-01-16 at 3 19 59 AM

@IanButterworth IanButterworth changed the title add an info popup Add an info popup and zoom buttons Jan 16, 2022
Copy link
Owner

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Big step forward for usability.

Too bad about the difficulty of running the test. It would be nice if we could couple the Close button to an Observable, but that can be separate. We should merge this without the test since I think it's a strict improvement.

src/ProfileView.jl Outdated Show resolved Hide resolved
src/ProfileView.jl Outdated Show resolved Hide resolved
src/ProfileView.jl Outdated Show resolved Hide resolved
src/ProfileView.jl Outdated Show resolved Hide resolved
Copy link
Owner

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready, and tag a new release.

@IanButterworth IanButterworth merged commit 4014d38 into timholy:master Jan 16, 2022
@IanButterworth IanButterworth deleted the ib/info_popup branch January 16, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants