Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme and default theme switching #193

Merged
merged 3 commits into from
Jan 23, 2022

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Jan 17, 2022

Adds ProfileView.set_theme!(:dark) for a dark mode.

Some limitations:

Both of these are with the system in dark mode and ProfileView set to :dark

Ubuntu:
Screenshot from 2022-01-17 16-09-28

MacOS:
Screen Shot 2022-01-17 at 3 57 45 PM

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #193 (83d5a57) into master (7d4c8c4) will increase coverage by 0.07%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   79.92%   80.00%   +0.07%     
==========================================
  Files           2        2              
  Lines         274      275       +1     
==========================================
+ Hits          219      220       +1     
  Misses         55       55              
Impacted Files Coverage Δ
src/ProfileView.jl 85.93% <92.30%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4c8c4...83d5a57. Read the comment docs.

@IanButterworth IanButterworth merged commit 6b7e47e into timholy:master Jan 23, 2022
@IanButterworth IanButterworth deleted the ib/default_themes branch January 23, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants