Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime to window title #196

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

IanButterworth
Copy link
Collaborator

Implements #194 but instead adds it to the end of the window name, even if a custom one is provided.

I think knowing the order that windows were opened in may always be of value
Screen Shot 2022-01-22 at 5 05 05 PM

Closes #194

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #196 (7357cf2) into master (6b7e47e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files           2        2           
  Lines         273      273           
=======================================
  Hits          218      218           
  Misses         55       55           
Impacted Files Coverage Δ
src/ProfileView.jl 85.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b7e47e...7357cf2. Read the comment docs.

@timholy
Copy link
Owner

timholy commented Jan 23, 2022

I can go with this. I worry a bit about the cognitive load of comparing times, especially if the user has gone to the trouble to give each window a unique name anyway (now we're adding a distractor with no new information).

@IanButterworth
Copy link
Collaborator Author

That's a good point. How about it's only shown for @profview given there the API isn't currently exposed for setting the window name? I think that might make more sense than appending it to a ProfileView.view() anyway because I think the time is informative wrt. the data collected, not when the window opened.

I'll give this another go

@IanButterworth
Copy link
Collaborator Author

Updated. Also, I don't feel strongly about this. Just an idea. I'd be happy to leave it out

@timholy
Copy link
Owner

timholy commented Mar 3, 2023

I like it. Let's do it.

@timholy timholy merged commit 9a97bbd into timholy:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the window name default include the time
2 participants