Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw the whole image in icicle mode because the text bbox is malformed #199

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

IanButterworth
Copy link
Collaborator

Just redraws the whole image in icicle mode to work around a bug with the text bbox when the coordinate system is inverted.

I couldn't figure out a fix, so this is a workaround. The window seems just as responsive to me.


Issue

Screenshot from 2022-01-23 02-21-09

To illustrate with random colors in place of the redraw.
:flame looks good
Screenshot from 2022-01-23 03-04-44

:icicle
Screenshot from 2022-01-23 03-03-00

@timholy
Copy link
Owner

timholy commented Jan 23, 2022

:flame looks messed up too: there are fat bars drawn over skinny ones. Is that an artifact of how you captured it or actually present?

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #199 (345a9a0) into master (7d4c8c4) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   79.92%   79.77%   -0.15%     
==========================================
  Files           2        2              
  Lines         274      272       -2     
==========================================
- Hits          219      217       -2     
  Misses         55       55              
Impacted Files Coverage Δ
src/ProfileView.jl 85.77% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4c8c4...345a9a0. Read the comment docs.

@IanButterworth
Copy link
Collaborator Author

I think that's just an illusion with the shapes overlaying. Interactively it looks correct

@timholy timholy merged commit 6bed3ad into timholy:master Mar 3, 2023
@timholy
Copy link
Owner

timholy commented Mar 3, 2023

Thanks! Sorry I didn't notice this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants