More fixes, tests, and polish #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were effectively excluding them on our initial parse, so we have to exclude them later too.
Also provide a couple of more typeasserts where appropriate (may improve performance)
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
+ Coverage 56.36% 75.1% +18.74%
==========================================
Files 1 1
Lines 220 229 +9
==========================================
+ Hits 124 172 +48
+ Misses 96 57 -39
Continue to review full report at Codecov.
|
timholy
force-pushed
the
teh/tests
branch
3 times, most recently
from
4fffdb1
to
ed35eac
Compare
oschulz
pushed a commit
to oschulz/Revise.jl
that referenced
this pull request
Nov 20, 2018
manifest: try deleting HeaderREPLs version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.