-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make jest/expect an peer deps? #81
Comments
I second this with the additional concern that Jest v24's dependency tree depends on two deprecated packages, namely resolve-url and urix, see:
EDIT: the same also goes for set-value, see:
|
@timkindberg If you are in favor of this change, I can try to create PR. |
Yes pls I keep trying to find some time but it's a busy time when kids are going back to school. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently jest-when use expect v24, unless user of library also use jest v24 whole swats of jest specific dependencies are duplicated.
I suggest that jest-when declare jest as peer dep with version like "jest": ">= 24"
The text was updated successfully, but these errors were encountered: