Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): make jest an peer dependancy #84

Merged
merged 3 commits into from
Sep 19, 2021

Conversation

chyzwar
Copy link
Contributor

@chyzwar chyzwar commented Sep 12, 2021

This address #81. I tested with jest 24, 25, 26 and 27, it should work with other versions as well. This could be released as non-breaking change. My concern is that his still imports jesmineUtils from private module api see https://github.com/facebook/jest/blob/d6e5ddb0c3c1af54f443f225aa14cdf07c7bb593/packages/expect/package.json#L12

I think we should raise issue on jest repo to expose equals in public API of expect package.

@timkindberg
Copy link
Owner

Ok so even with the separate concern of importing equals from jasmineUtils you think this is safe to merge as a non-breaking minor release?

@chyzwar
Copy link
Contributor Author

chyzwar commented Sep 12, 2021

Yes, In my opinion it should safe but can run this patch tomorrow on large codebase at work. We use jest-when in few hundred tests.

@chyzwar
Copy link
Contributor Author

chyzwar commented Sep 12, 2021

I run on one of our codebases, it has 97 imports of jest-when, all tests passed and possibly slightly faster.

@ericcornelissen
Copy link

It's a minor data point but I run the tests for ericcornelissen/svgo-action successfully when using these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants