Add ability to match/assert on all the args at once #67
+225
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkindberg
commented
Apr 30, 2021
mcous
approved these changes
Apr 30, 2021
timkindberg
force-pushed
the
when-allargs
branch
from
11af2bc
to
e42f438
Compare
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 108 116 +8
=========================================
+ Hits 108 116 +8
Continue to review full report at Codecov.
|
timkindberg
force-pushed
the
when-allargs
branch
from
e42f438
to
544bb5c
Compare
|
@mcous I'm really liking this feature! Check out the documentation changes I made. |
timkindberg
force-pushed
the
when-allargs
branch
from
544bb5c
to
3e7805b
Compare
mcous
reviewed
Apr 30, 2021
- New when.allArgs matcher. Instructs jest-when to hand over the full set of arguments to the matcher. This allows a dev to perform more complex matches, or in some cases write more succinct matching logic.
timkindberg
force-pushed
the
when-allargs
branch
from
3e7805b
to
7163307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
@mcous Can you please review and see if this might meet your needs? I have one test in particular that address your specific use case.
Still needs: