Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP move to pycapsule #3

Merged
merged 4 commits into from
Feb 24, 2024
Merged

WIP move to pycapsule #3

merged 4 commits into from
Feb 24, 2024

Conversation

timkpaine
Copy link
Owner

@timkpaine timkpaine commented Feb 23, 2024

apache/arrow#38010
apache/arrow#39195
finos/perspective#1157
apache/arrow#10488

This PR completely removes the pyarrow dependency and uses the new PyCapsule protocol to transfer data from a python layer (in this case the python library arrow_python_nocopy) to the c++ layer (in this case a C++ library called libarrow-python-nocopy.so) entirely over the C API without any weird hackery (e.g. finos/perspective#1157 (comment))

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.87%. Comparing base (e1ed4d1) to head (14340ea).

Files Patch % Lines
arrow_python_nocopy/__init__.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   84.72%   87.87%   +3.15%     
==========================================
  Files           2        2              
  Lines          72       66       -6     
==========================================
- Hits           61       58       -3     
+ Misses         11        8       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 24, 2024

Test Results

10 tests  ±0   10 ✅ ±0   0s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 14340ea. ± Comparison against base commit e1ed4d1.

♻️ This comment has been updated with latest results.

@timkpaine timkpaine merged commit 4a91d20 into main Feb 24, 2024
10 of 12 checks passed
@timkpaine timkpaine deleted the tkp/pycapsule branch February 24, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant